Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

webrtc/modules/BUILD.gn

Index: webrtc/modules/BUILD.gn
diff --git a/webrtc/modules/BUILD.gn b/webrtc/modules/BUILD.gn
index 6c472a399f0dae5fd090e7a4a7343591978367b8..4c018168be55471070143896a5f81ba8cf6967c4 100644
--- a/webrtc/modules/BUILD.gn
+++ b/webrtc/modules/BUILD.gn
@@ -70,6 +70,7 @@ if (rtc_include_tests) {
       "../system_wrappers",
       "../test:test_support",
       "../test:test_support_main",
+      "//testing/gmock",
       "//testing/gtest",
     ]
 
@@ -95,6 +96,20 @@ if (rtc_include_tests) {
       "video_coding/codecs/vp8/test/vp8_impl_unittest.cc",
     ]
 
+    if (rtc_desktop_capture_supported) {
+      deps += [ "desktop_capture" ]
+      sources += [
+        "desktop_capture/rgba_color.cc",

[kjellander_webrtc, 2016/10/24 07:30:20]

Please, can we avoid adding duplicated code here. I suggest moving 
desktop_capture/rgba_color.*
desktop_capture/screen_drawer*
into a new source_set target 'desktop_capture_test_tools' in
webrtc/modules/desktop_capture/BUILD.gn

Then add a dependency on it here and in modules_unittests:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/BUILD.gn?rcl=...

[Hzj_jie, 2016/10/24 20:50:54]

Done.

[kjellander_webrtc, 2016/10/25 07:01:48]

Please move the target into webrtc/modules/desktop_capture/BUILD.gn
Having it in webrtc/modules/BUILD.gn doesn't make sense.

+        "desktop_capture/rgba_color.h",
+        "desktop_capture/screen_capturer_integration_test.cc",
+        "desktop_capture/screen_drawer.cc",
+        "desktop_capture/screen_drawer.h",
+        "desktop_capture/screen_drawer_linux.cc",
+        "desktop_capture/screen_drawer_mac.cc",
+        "desktop_capture/screen_drawer_win.cc",
+      ]
+    }
+
     data = modules_tests_resources
 
     if (is_android) {