Move ScreenCapturer 'real' tests out of screen_capturer_unittest.cc.

webrtc/modules/BUILD.gn

 # Copyright (c) 2016 The WebRTC project authors. All Rights Reserved.
 #
 # Use of this source code is governed by a BSD-style license
 # that can be found in the LICENSE file in the root of the source
 # tree. An additional intellectual property rights grant can be found
 # in the file PATENTS.  All contributing project authors may
 # be found in the AUTHORS file in the root of the source tree.
 
 import("../build/webrtc.gni")
 import("audio_coding/audio_coding.gni")
@@ skipping 52 matching lines @@
       "..:webrtc_common",
       "../common_video",
       "../modules/audio_coding",
       "../modules/rtp_rtcp",
       "../modules/utility",
       "../modules/video_coding",
       "../modules/video_coding:video_codecs_test_framework",
       "../system_wrappers",
       "../test:test_support",
       "../test:test_support_main",
+      "//testing/gmock",
       "//testing/gtest",
     ]
 
     sources = [
       "audio_coding/test/APITest.cc",
       "audio_coding/test/Channel.cc",
       "audio_coding/test/EncodeDecodeTest.cc",
       "audio_coding/test/PCMFile.cc",
       "audio_coding/test/PacketLossTest.cc",
       "audio_coding/test/RTPFile.cc",
       "audio_coding/test/TestAllCodecs.cc",
       "audio_coding/test/TestRedFec.cc",
       "audio_coding/test/TestStereo.cc",
       "audio_coding/test/TestVADDTX.cc",
       "audio_coding/test/Tester.cc",
       "audio_coding/test/TwoWayCommunication.cc",
       "audio_coding/test/iSACTest.cc",
       "audio_coding/test/opus_test.cc",
       "audio_coding/test/target_delay_unittest.cc",
       "audio_coding/test/utility.cc",
       "rtp_rtcp/test/testFec/test_fec.cc",
       "video_coding/codecs/test/videoprocessor_integrationtest.cc",
       "video_coding/codecs/vp8/test/vp8_impl_unittest.cc",
     ]
 
+    if (rtc_desktop_capture_supported) {
+      deps += [ "desktop_capture" ]
+      sources += [
+        "desktop_capture/rgba_color.cc",

[kjellander_webrtc, 2016/10/24 07:30:20]

Please, can we avoid adding duplicated code here. I suggest moving 
desktop_capture/rgba_color.*
desktop_capture/screen_drawer*
into a new source_set target 'desktop_capture_test_tools' in
webrtc/modules/desktop_capture/BUILD.gn

Then add a dependency on it here and in modules_unittests:
https://cs.chromium.org/chromium/src/third_party/webrtc/modules/BUILD.gn?rcl=...

[Hzj_jie, 2016/10/24 20:50:54]

Done.

[kjellander_webrtc, 2016/10/25 07:01:48]

Please move the target into webrtc/modules/desktop_capture/BUILD.gn
Having it in webrtc/modules/BUILD.gn doesn't make sense.

+        "desktop_capture/rgba_color.h",
+        "desktop_capture/screen_capturer_integration_test.cc",
+        "desktop_capture/screen_drawer.cc",
+        "desktop_capture/screen_drawer.h",
+        "desktop_capture/screen_drawer_linux.cc",
+        "desktop_capture/screen_drawer_mac.cc",
+        "desktop_capture/screen_drawer_win.cc",
+      ]
+    }
+
     data = modules_tests_resources
 
     if (is_android) {
       deps += [ "//testing/android/native_test:native_test_native_code" ]
       shard_timeout = 900
     }
 
     if (is_ios) {
       deps += [ ":modules_tests_bundle_data" ]
     }
@@ skipping 628 matching lines @@
       "../test:test_common",
       "../test:test_support_main",
       "remote_bitrate_estimator:bwe_simulator_lib",
       "video_capture",
       "//testing/gmock",
       "//testing/gtest",
       "//third_party/gflags",
     ]
   }
 }