cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient

content/browser/renderer_host/compositor_impl_android.cc

Index: content/browser/renderer_host/compositor_impl_android.cc
diff --git a/content/browser/renderer_host/compositor_impl_android.cc b/content/browser/renderer_host/compositor_impl_android.cc
index 450adca102409a3c63450bda187a371c81bf584a..a8c57db192d8e3b8339e29811b4da3304c541210 100644
--- a/content/browser/renderer_host/compositor_impl_android.cc
+++ b/content/browser/renderer_host/compositor_impl_android.cc
@@ -774,8 +774,8 @@ bool CompositorImpl::SupportsETC1NonPowerOfTwo() const {
   return gpu_capabilities_.texture_format_etc1_npot;
 }
 
-void CompositorImpl::DidPostSwapBuffers() {
-  TRACE_EVENT0("compositor", "CompositorImpl::DidPostSwapBuffers");
+void CompositorImpl::DidSubmitCompositorFrame() {
+  TRACE_EVENT0("compositor", "CompositorImpl::DidSubmitCompositorFrame");
   pending_swapbuffers_++;
 }
 
@@ -786,13 +786,8 @@ void CompositorImpl::DidReceiveCompositorFrameAck() {
   client_->OnSwapBuffersCompleted(pending_swapbuffers_);
 }
 
-void CompositorImpl::DidAbortSwapBuffers() {
-  TRACE_EVENT0("compositor", "CompositorImpl::DidAbortSwapBuffers");
-  // This really gets called only once from
-  // SingleThreadProxy::DidLoseCompositorFrameSinkOnImplThread() when the
-  // context was lost.
-  if (host_->IsVisible())
-    host_->SetNeedsCommit();

[piman, 2016/10/21 23:44:22]

What makes it ok to remove? Is there another mechanism (BeginFrame?) to do this
instead?

[danakj, 2016/10/21 23:46:20]

Oh right this one. SingleThreadProxy::DidLoseCompositorFrameSinkOnImplThread()
used to call this. It also calls layer_tree_host_->DidLoseCompositorFrameSink()
which does SetNeedsCommit() unconditionally. So this was conditionally calling
it a 2nd time.

https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_in_process.cc?r...

+void CompositorImpl::DidLoseCompositorFrameSink() {
+  TRACE_EVENT0("compositor", "CompositorImpl::DidLoseCompositorFrameSink");
   client_->OnSwapBuffersCompleted(0);
 }