Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3781)

Unified Diff: ash/wm/window_animations.cc

Issue 2444563002: cc: Remove "SwapBuffers" naming from LayerTreeHostSingleThreadClient (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/window_animations.cc
diff --git a/ash/wm/window_animations.cc b/ash/wm/window_animations.cc
index f8eb4094dc9a4ac65de4b95687235209021e3210..1772844206de4d4ce0867db533bd410bdabc67fb 100644
--- a/ash/wm/window_animations.cc
+++ b/ash/wm/window_animations.cc
@@ -249,8 +249,8 @@ bool AnimateHideWindow(aura::Window* window) {
}
// Observer for a window cross-fade animation. If either the window closes or
-// the layer's animation completes or compositing is aborted due to GPU crash,
-// it deletes the layer and removes itself as an observer.
+// the layer's animation completes, it deletes the layer and removes itself as
+// an observer.
class CrossFadeObserver : public ui::CompositorObserver,
public aura::WindowObserver,
public ui::ImplicitAnimationObserver {
@@ -274,10 +274,6 @@ class CrossFadeObserver : public ui::CompositorObserver,
void OnCompositingStarted(ui::Compositor* compositor,
base::TimeTicks start_time) override {}
void OnCompositingEnded(ui::Compositor* compositor) override {}
- void OnCompositingAborted(ui::Compositor* compositor) override {
- // Triggers OnImplicitAnimationsCompleted() to be called and deletes us.
- layer_owner_->root()->GetAnimator()->StopAnimating();
- }
void OnCompositingLockStateChanged(ui::Compositor* compositor) override {}
void OnCompositingShuttingDown(ui::Compositor* compositor) override {}
oshima 2016/10/21 23:33:25 nit: looks like we can remove CompositorObserver f
danakj 2016/10/21 23:37:42 Agreed! Done.

Powered by Google App Engine
This is Rietveld 408576698