Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2380)

Unified Diff: chrome/browser/chromeos/login/session/chrome_session_manager.h

Issue 2444383008: session_manager: Create ChromeSessionManager early (Closed)
Patch Set: for #4 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/session/chrome_session_manager.h
diff --git a/chrome/browser/chromeos/login/session/chrome_session_manager.h b/chrome/browser/chromeos/login/session/chrome_session_manager.h
index 2a46d6c042dbcee5ac1506941535ed4b44bdcb15..b8e09214d4f9a6a767d5cf77a0d3cbbe9c142223 100644
--- a/chrome/browser/chromeos/login/session/chrome_session_manager.h
+++ b/chrome/browser/chromeos/login/session/chrome_session_manager.h
@@ -18,19 +18,23 @@ namespace chromeos {
class ChromeSessionManager : public session_manager::SessionManager {
public:
- static std::unique_ptr<session_manager::SessionManager> CreateSessionManager(
- const base::CommandLine& parsed_command_line,
- Profile* profile,
- bool is_running_test);
-
- private:
- explicit ChromeSessionManager(
- session_manager::SessionManagerDelegate* delegate);
+ ChromeSessionManager();
~ChromeSessionManager() override;
+ // Initialize session manager on browser starts up. Runs different code
+ // path based on command line flags and policy. Possible scenarios include:
+ // - Launches pre-session UI such as out-of-box or login;
+ // - Launches the auto launched kiosk app;
+ // - Resumes user sessions on crash-and-restart;
+ // - Starts a stub login session for dev or test;
+ void Initialize(const base::CommandLine& parsed_command_line,
+ Profile* profile,
+ bool is_running_test);
+
// session_manager::SessionManager:
void SessionStarted() override;
+ private:
DISALLOW_COPY_AND_ASSIGN(ChromeSessionManager);
};

Powered by Google App Engine
This is Rietveld 408576698