Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: chrome/browser/chromeos/chrome_browser_main_chromeos.cc

Issue 2444383008: session_manager: Create ChromeSessionManager early (Closed)
Patch Set: for #4 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/BUILD.gn ('k') | chrome/browser/chromeos/login/session/chrome_session_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/chrome_browser_main_chromeos.cc
diff --git a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
index b56d85226087e83652dc2dc29c89cc5a10dd0e18..98b5799d9dbd1beb3c5f2cc4376e577b091a9547 100644
--- a/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
+++ b/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
@@ -53,6 +53,7 @@
#include "chrome/browser/chromeos/login/helper.h"
#include "chrome/browser/chromeos/login/lock/screen_locker.h"
#include "chrome/browser/chromeos/login/login_wizard.h"
+#include "chrome/browser/chromeos/login/session/chrome_session_manager.h"
#include "chrome/browser/chromeos/login/session/user_session_manager.h"
#include "chrome/browser/chromeos/login/startup_utils.h"
#include "chrome/browser/chromeos/login/users/chrome_user_manager.h"
@@ -436,6 +437,7 @@ void ChromeBrowserMainPartsChromeos::PreProfileInit() {
// -- just before CreateProfile().
g_browser_process->platform_part()->InitializeChromeUserManager();
+ g_browser_process->platform_part()->InitializeSessionManager();
ScreenLocker::InitClass();
@@ -635,8 +637,8 @@ void ChromeBrowserMainPartsChromeos::PostProfileInit() {
// Initialize the network portal detector for Chrome OS. The network
// portal detector starts to listen for notifications from
// NetworkStateHandler and initiates captive portal detection for
- // active networks. Should be called before call to CreateSessionManager,
- // because it depends on NetworkPortalDetector.
+ // active networks. Should be called before call to initialize
+ // ChromeSessionManager because it depends on NetworkPortalDetector.
InitializeNetworkPortalDetector();
{
#if defined(GOOGLE_CHROME_BUILD)
@@ -660,9 +662,8 @@ void ChromeBrowserMainPartsChromeos::PostProfileInit() {
manager->SetState(session_manager->GetDefaultIMEState(profile()));
bool is_running_test = parameters().ui_task != nullptr;
- g_browser_process->platform_part()->InitializeSessionManager(
+ g_browser_process->platform_part()->session_manager()->Initialize(
parsed_command_line(), profile(), is_running_test);
- g_browser_process->platform_part()->SessionManager()->Start();
// Guest user profile is never initialized with locale settings,
// so we need special handling for Guest session.
@@ -877,9 +878,8 @@ void ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun() {
// parts of WebUI depends on NetworkPortalDetector.
network_portal_detector::Shutdown();
- g_browser_process->platform_part()->DestroyChromeUserManager();
-
g_browser_process->platform_part()->ShutdownSessionManager();
+ g_browser_process->platform_part()->DestroyChromeUserManager();
}
void ChromeBrowserMainPartsChromeos::PostDestroyThreads() {
« no previous file with comments | « chrome/browser/chromeos/BUILD.gn ('k') | chrome/browser/chromeos/login/session/chrome_session_manager.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698