Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2444383002: Fixing a crash when clicking download notification while Chrome is killed (Closed)

Created:
4 years, 1 month ago by qinmin
Modified:
4 years, 1 month ago
Reviewers:
gone
CC:
chromium-reviews, asanka, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Fixing a crash when clicking download notification while Chrome is killed When clicking on download notification, Chrome checks if the download file can be opened by itself. This calls into a native function. However, if user kills Chrome, and then clicks the notification, this generates a Broadcast to Chrome. When BroadcastReceiver runs, native library is not loaded. As a result, this generates a crash. This CL solves the problem by performing the mime type checking when download completes. So that we don't need to check it when BroadcastReceiver runs TBR=dfalcantara@chromium.org BUG=658012 Review-Url: https://codereview.chromium.org/2446643004 Cr-Commit-Position: refs/heads/master@{#427204} (cherry picked from commit ff25b0171fdd6663cc16000071c8d65c3cde1cb0) Committed: https://chromium.googlesource.com/chromium/src/+/e92cfc834916b71c7e7dd8613d5fd2ba7da706bc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -39 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadBroadcastReceiver.java View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerDelegate.java View 4 chunks +3 lines, -5 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadManagerService.java View 13 chunks +32 lines, -15 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotificationService.java View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/DownloadNotifier.java View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/download/SystemDownloadNotifier.java View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/offlinepages/downloads/OfflinePageNotificationBridge.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadManagerServiceTest.java View 1 chunk +15 lines, -10 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/DownloadNotificationServiceTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/download/SystemDownloadNotifierTest.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
qinmin
4 years, 1 month ago (2016-10-25 17:09:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e92cfc834916b71c7e7dd8613d5fd2ba7da706bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698