Adding/renaming a folder in the bookmark manager should not hide the icon.

chrome/browser/resources/bookmark_manager/css/bmm.css

Index: chrome/browser/resources/bookmark_manager/css/bmm.css
diff --git a/chrome/browser/resources/bookmark_manager/css/bmm.css b/chrome/browser/resources/bookmark_manager/css/bmm.css
index 0f12426e9d8415cd91d335d03d0956e9491fabbc..d34d96ec50d84d2527154ec14690c3d6de3b90a9 100644
--- a/chrome/browser/resources/bookmark_manager/css/bmm.css
+++ b/chrome/browser/resources/bookmark_manager/css/bmm.css
@@ -56,6 +56,7 @@ list .label {
 list .label-img-wrapper {
   display: inline-block; /* Makes the image start-align in RTL. */
   width: 20px;
+  z-index: -1;

[Peter Kasting, 2016/10/26 01:49:57]

Without this, the input field, which has a -webkit-margin-start of -4px (see
line 142), looks truncated on the left where it overlaps this div, even though
the div "appears" to be empty in this region.

I don't know exactly what draws the gradient background on selected BMM rows,
but that background is what we see in this region instead.  Maybe it's getting
separately drawn on each individual div.

We don't want to fix this by removing the -4px margin, or the text will shift
horizontally when we start/stop editing.

[Dan Beam, 2016/10/27 03:56:16]

Acknowledged.

 }
 
 <if expr="not is_macosx and not is_ios">
@@ -135,7 +136,7 @@ html[dir=rtl] list > * > button {
 
 /* Edit mode */
 
-list [editing] .label input,
+list [editing] .label-text input,

[Peter Kasting, 2016/10/26 01:49:57]

This change should have no effect, nor should the one on line 166, but they were
made to be consistent with line 176.

[Dan Beam, 2016/10/27 03:56:16]

Acknowledged.

 list [editing] .url input {
   -webkit-margin-end: 4px;
   -webkit-margin-start: -4px;
@@ -162,7 +163,7 @@ list [editing] .url input {
 }
 
 <if expr="is_macosx">
-list .label input,
+list .label-text input,
 list .url input {
   outline: none;
 }
@@ -172,7 +173,7 @@ list > [editing] {
   overflow: visible;
 }
 
-list [editing] .label,
+list [editing] .label-text,

[Peter Kasting, 2016/10/26 01:49:57]

I made this change speculatively.  Due to
https://codereview.chromium.org/2350473003 , whatever purpose the "overflow:
visible" style here served was no effective.  Before that change, .label was the
direct parent of the <input> element; afterwards, .label-text was introduced to
fill that role, and given its own "overflow: hidden" style (see line 71), which
would override this.

So this aims to return to the previous behavior.  But I don't know what effect
toggling these overflow values actually has in this specific case, so I'm not
sure how to test that this is really fixing a bug.  Help :(

[Dan Beam, 2016/10/27 03:56:17]

¯\_(ツ)_/¯

[Peter Kasting, 2016/10/27 06:00:26]

:(

I'm inclined to rip out the overflow fiddling entirely and see what breaks,
except I wouldn't notice, and months later it'd end up being tasked to me to
fix. :P

This whole file needs way more "Why do we have this" comments.

[Dan Beam, 2016/10/27 17:27:55]

i mean, i could find out, but this code is basicallly deprecated in my mind and
i'd just prefer to focus on its replacement rather than understanding old code
with all authors gone

 list [editing] .url,
 list [editing] > * {
   overflow: visible;