Bookmark manager folder icon cleanups for list pane.

Bookmark manager folder icon cleanups for list pane.

* Existing support for 2x scale wasn't actually working.  Now it is.
* Uses chrome://theme/ URLs instead of direct references to image files on disk
  (will make mucking with that imagery in a separate patch easier, among other
  things).
* Uses transforms to flip folder images for RTL instead of dedicated resources.

For now there's still some ugliness since Mac is using a different set of
resources (file locations, resource IDs) than other platforms.  That will all be
cleaned up later.

BUG=564112
TEST=Run chrome with --force-device-scale-factor=2, open bookmark manager, check that folder icons in right-hand pane are high-res
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/71fa2e9ca7722388da15099748e2772f9f1640e7
Cr-Commit-Position: refs/heads/master@{#419988}

[Peter Kasting, 2016-09-17 01:41:01]

Description was changed from

==========
Bookmark manager folder icon cleanups for list pane.

* Existing support for 2x scale wasn't actually working.  Now it is.
* Uses chrome://theme/ URLs instead of direct references to image files on disk
  (will make mucking with that imagery in a separate patch easier, among other
  things).
* Uses transforms to flip folder images for RTL instead of dedicated resources.

For now there's still some ugliness since Mac is using a different set of
resources (file locations, resource IDs) than other platforms.  That will all be
cleaned up later.

BUG=564112
TEST=Run chrome with --force-device-scale-factor=2, open bookmark manager, check
that folder icons in right-hand pane are high-res
==========

to

==========
Bookmark manager folder icon cleanups for list pane.

* Existing support for 2x scale wasn't actually working.  Now it is.
* Uses chrome://theme/ URLs instead of direct references to image files on disk
  (will make mucking with that imagery in a separate patch easier, among other
  things).
* Uses transforms to flip folder images for RTL instead of dedicated resources.

For now there's still some ugliness since Mac is using a different set of
resources (file locations, resource IDs) than other platforms.  That will all be
cleaned up later.

BUG=564112
TEST=Run chrome with --force-device-scale-factor=2, open bookmark manager, check
that folder icons in right-hand pane are high-res
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Peter Kasting, 2016-09-17 01:42:43]

pkasting@chromium.org changed reviewers:
+ dbeam@chromium.org

[Peter Kasting, 2016-09-17 01:42:53]

The CQ bit was checked by pkasting@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-17 01:43:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-17 02:44:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-17 02:44:29]

Dry run: This issue passed the CQ dry run.

[Peter Kasting, 2016-09-20 21:43:15]

Ping.

[Dan Beam, 2016-09-21 03:14:23]

lgtm

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/bo...
File chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js (right):

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/bo...
chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js:440: <if
expr="is_macosx">
doing this at compile time is arguably better, but you can also do cr.isMac at
runtime (just fyi if you didn't know)

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/co...
File chrome/browser/resources/component_extension_resources.grd (right):

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/co...
chrome/browser/resources/component_extension_resources.grd:38: <include
name="IDR_BOOKMARK_MANAGER_BOOKMARK_BMM_LIST_JS"
file="bookmark_manager/js/bmm/bookmark_list.js" flattenhtml="true"
type="BINDATA" />
if we could make this a <structure> and use preprocess="true", less kittens
would be eaten by domo-kun

[Peter Kasting, 2016-09-21 04:52:35]

Landing.

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/bo...
File chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js (right):

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/bo...
chrome/browser/resources/bookmark_manager/js/bmm/bookmark_list.js:440: <if
expr="is_macosx">
On 2016/09/21 03:14:23, Dan Beam wrote:
> doing this at compile time is arguably better, but you can also do cr.isMac at
> runtime (just fyi if you didn't know)

I didn't know!  I'd actually prefer that, since it lets me avoid the .grd change
(and this is intended to be temporary anyway).

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/co...
File chrome/browser/resources/component_extension_resources.grd (right):

https://codereview.chromium.org/2350473003/diff/1/chrome/browser/resources/co...
chrome/browser/resources/component_extension_resources.grd:38: <include
name="IDR_BOOKMARK_MANAGER_BOOKMARK_BMM_LIST_JS"
file="bookmark_manager/js/bmm/bookmark_list.js" flattenhtml="true"
type="BINDATA" />
On 2016/09/21 03:14:23, Dan Beam wrote:
> if we could make this a <structure> and use preprocess="true", less kittens
> would be eaten by domo-kun

This change got reverted since I changed the other spot to being done at
runtime, so I assume that what you were suggesting is no longer interesting.  (I
don't really know what the ramifications of your suggestion are.)

[Peter Kasting, 2016-09-21 04:52:40]

The CQ bit was checked by pkasting@chromium.org

[Peter Kasting, 2016-09-21 04:52:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2350473003/#ps20001
(title: "Runtime check")

[commit-bot: I haz the power, 2016-09-21 04:52:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 06:26:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-09-21 06:28:03]

Description was changed from

==========
Bookmark manager folder icon cleanups for list pane.

* Existing support for 2x scale wasn't actually working.  Now it is.
* Uses chrome://theme/ URLs instead of direct references to image files on disk
  (will make mucking with that imagery in a separate patch easier, among other
  things).
* Uses transforms to flip folder images for RTL instead of dedicated resources.

For now there's still some ugliness since Mac is using a different set of
resources (file locations, resource IDs) than other platforms.  That will all be
cleaned up later.

BUG=564112
TEST=Run chrome with --force-device-scale-factor=2, open bookmark manager, check
that folder icons in right-hand pane are high-res
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Bookmark manager folder icon cleanups for list pane.

* Existing support for 2x scale wasn't actually working.  Now it is.
* Uses chrome://theme/ URLs instead of direct references to image files on disk
  (will make mucking with that imagery in a separate patch easier, among other
  things).
* Uses transforms to flip folder images for RTL instead of dedicated resources.

For now there's still some ugliness since Mac is using a different set of
resources (file locations, resource IDs) than other platforms.  That will all be
cleaned up later.

BUG=564112
TEST=Run chrome with --force-device-scale-factor=2, open bookmark manager, check
that folder icons in right-hand pane are high-res
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/71fa2e9ca7722388da15099748e2772f9f1640e7
Cr-Commit-Position: refs/heads/master@{#419988}
==========

[commit-bot: I haz the power, 2016-09-21 06:28:04]

Patchset 2 (id:??) landed as
https://crrev.com/71fa2e9ca7722388da15099748e2772f9f1640e7
Cr-Commit-Position: refs/heads/master@{#419988}