Remove function casting from Libsecret tests

Remove function casting from Libsecret tests

Some libsecret data types are hidden. For our tests, we introduce our
own data types and cast them to the expected types. Previously, that was
done by casting the mocked functions. This is undefined behaviour,
thefore we are moving the casting inside the mock methods.

BUG=658723
Committed: https://crrev.com/8a42817875f7395f54bc567a319b79062b489261
Cr-Commit-Position: refs/heads/master@{#427331}

[cfroussios, 2016-10-25 09:26:52]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 09:27:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-10-25 09:34:22]

cfroussios@chromium.org changed reviewers:
+ vasilii@chromium.org

[commit-bot: I haz the power, 2016-10-25 10:17:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 10:17:17]

Dry run: This issue passed the CQ dry run.

[vasilii, 2016-10-25 11:42:57]

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/key...
File components/os_crypt/key_storage_libsecret_unittest.cc (right):

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_libsecret_unittest.cc:16: // cast to the correct
signature. We can reduce SecretValue to an std::string,
Obsolete comment.

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_libsecret_unittest.cc:157: return
reinterpret_cast<SecretValue*>(item);
static_assert(std::is_same<MockSecretValue, MockSecretItem>::value, "bla bla
bla");

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/lib...
File components/os_crypt/libsecret_util_linux.cc (right):

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/lib...
components/os_crypt/libsecret_util_linux.cc:18: nullptr;
In fact global variables are guaranteed to be zero-initialized. Though, it
doesn't harm.

[cfroussios, 2016-10-25 12:08:49]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 12:09:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-10-25 12:14:19]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 12:14:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[cfroussios, 2016-10-25 12:14:40]

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/key...
File components/os_crypt/key_storage_libsecret_unittest.cc (right):

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_libsecret_unittest.cc:16: // cast to the correct
signature. We can reduce SecretValue to an std::string,
On 2016/10/25 11:42:57, vasilii wrote:
> Obsolete comment.

Done.

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/key...
components/os_crypt/key_storage_libsecret_unittest.cc:157: return
reinterpret_cast<SecretValue*>(item);
On 2016/10/25 11:42:57, vasilii wrote:
> static_assert(std::is_same<MockSecretValue, MockSecretItem>::value, "bla bla
> bla");

Done.

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/lib...
File components/os_crypt/libsecret_util_linux.cc (right):

https://codereview.chromium.org/2444313002/diff/20001/components/os_crypt/lib...
components/os_crypt/libsecret_util_linux.cc:18: nullptr;
On 2016/10/25 11:42:57, vasilii wrote:
> In fact global variables are guaranteed to be zero-initialized. Though, it
> doesn't harm.

Acknowledged.

[vasilii, 2016-10-25 12:19:57]

lgtm

[commit-bot: I haz the power, 2016-10-25 12:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 12:27:19]

Dry run: Try jobs failed on following builders:
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cfroussios, 2016-10-25 12:35:09]

The CQ bit was checked by cfroussios@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 12:35:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 13:10:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 13:10:28]

Dry run: This issue passed the CQ dry run.

[cfroussios, 2016-10-25 13:11:37]

The CQ bit was checked by cfroussios@chromium.org

[cfroussios, 2016-10-25 13:11:37]

The patchset sent to the CQ was uploaded after l-g-t-m from vasilii@chromium.org
Link to the patchset: https://codereview.chromium.org/2444313002/#ps80001
(title: "typo")

[commit-bot: I haz the power, 2016-10-25 13:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-25 13:16:41]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-25 13:20:12]

Description was changed from

==========
Remove function casting from Libsecret tests

Some libsecret data types are hidden. For our tests, we introduce our
own data types and cast them to the expected types. Previously, that was
done by casting the mocked functions. This is undefined behaviour,
thefore we are moving the casting inside the mock methods.

BUG=658723
==========

to

==========
Remove function casting from Libsecret tests

Some libsecret data types are hidden. For our tests, we introduce our
own data types and cast them to the expected types. Previously, that was
done by casting the mocked functions. This is undefined behaviour,
thefore we are moving the casting inside the mock methods.

BUG=658723

Committed: https://crrev.com/8a42817875f7395f54bc567a319b79062b489261
Cr-Commit-Position: refs/heads/master@{#427331}
==========

[commit-bot: I haz the power, 2016-10-25 13:20:13]

Patchset 5 (id:??) landed as
https://crrev.com/8a42817875f7395f54bc567a319b79062b489261
Cr-Commit-Position: refs/heads/master@{#427331}