Remove function casting from Libsecret tests

components/os_crypt/libsecret_util_linux.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/os_crypt/libsecret_util_linux.h"
 
 #include <dlfcn.h>
 
 #include "base/logging.h"
 #include "base/strings/string_number_conversions.h"
 
 //
 // LibsecretLoader
 //
 
 decltype(
-    &::secret_password_store_sync) LibsecretLoader::secret_password_store_sync;
+    &::secret_password_store_sync) LibsecretLoader::secret_password_store_sync =
+    nullptr;

[vasilii, 2016/10/25 11:42:57]

In fact global variables are guaranteed to be zero-initialized. Though, it
doesn't harm.

[cfroussios, 2016/10/25 12:14:40]

Acknowledged.

 decltype(
-    &::secret_service_search_sync) LibsecretLoader::secret_service_search_sync;
+    &::secret_service_search_sync) LibsecretLoader::secret_service_search_sync =
+    nullptr;
 decltype(
-    &::secret_password_clear_sync) LibsecretLoader::secret_password_clear_sync;
-decltype(&::secret_item_get_secret) LibsecretLoader::secret_item_get_secret;
-decltype(&::secret_value_get_text) LibsecretLoader::secret_value_get_text;
+    &::secret_password_clear_sync) LibsecretLoader::secret_password_clear_sync =
+    nullptr;
+decltype(&::secret_item_get_secret) LibsecretLoader::secret_item_get_secret =
+    nullptr;
+decltype(&::secret_value_get_text) LibsecretLoader::secret_value_get_text =
+    nullptr;
 decltype(
-    &::secret_item_get_attributes) LibsecretLoader::secret_item_get_attributes;
+    &::secret_item_get_attributes) LibsecretLoader::secret_item_get_attributes =
+    nullptr;
 decltype(&::secret_item_load_secret_sync)
-    LibsecretLoader::secret_item_load_secret_sync;
-decltype(&::secret_value_unref) LibsecretLoader::secret_value_unref;
+    LibsecretLoader::secret_item_load_secret_sync = nullptr;
+decltype(&::secret_value_unref) LibsecretLoader::secret_value_unref = nullptr;
 
 bool LibsecretLoader::libsecret_loaded_ = false;
 
 const LibsecretLoader::FunctionInfo LibsecretLoader::kFunctions[] = {
     {"secret_item_get_secret",
      reinterpret_cast<void**>(&secret_item_get_secret)},
     {"secret_item_get_attributes",
      reinterpret_cast<void**>(&secret_item_get_attributes)},
     {"secret_item_load_secret_sync",
      reinterpret_cast<void**>(&secret_item_load_secret_sync)},
@@ skipping 96 matching lines @@
   name_values_.push_back(value);
   gpointer value_str =
       static_cast<gpointer>(const_cast<char*>(name_values_.back().c_str()));
   g_hash_table_insert(attrs_, name_str, value_str);
 }
 
 void LibsecretAttributesBuilder::Append(const std::string& name,
                                         int64_t value) {
   Append(name, base::Int64ToString(value));
 }