Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(932)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
index db130b3a2f97049789077f8d42789e0e40da8d8e..90a0590be53c27a3f810f35535bdcce0e48dbee8 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/ServiceWorkerCacheViews.js
@@ -36,13 +36,12 @@ WebInspector.ServiceWorkerCacheView.prototype = {
*/
_createDataGrid: function()
{
- var columns = [];
- columns.push({id: "number", title: WebInspector.UIString("#"), width: "50px"});
- columns.push({id: "request", title: WebInspector.UIString("Request")});
- columns.push({id: "response", title: WebInspector.UIString("Response")});
-
- var dataGrid = new WebInspector.DataGrid(columns, undefined, this._deleteButtonClicked.bind(this), this._updateData.bind(this, true));
- return dataGrid;
+ var columns = /** @type {!Array<!WebInspector.DataGrid.ColumnDescriptor>} */ ([
+ {id: "number", title: WebInspector.UIString("#"), width: "50px"},
+ {id: "request", title: WebInspector.UIString("Request")},
+ {id: "response", title: WebInspector.UIString("Response")}
+ ]);
+ return new WebInspector.DataGrid(columns, undefined, this._deleteButtonClicked.bind(this), this._updateData.bind(this, true));
},
_createEditorToolbar: function()

Powered by Google App Engine
This is Rietveld 408576698