Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)
Patch Set: changes Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html
diff --git a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html
index c88b73ba85de0a034cec6d483560e219cae22446..1967b053100f9d1a279b46eea0c95704838d2790 100644
--- a/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html
+++ b/third_party/WebKit/LayoutTests/inspector/profiler/heap-snapshot-summary-sorting-instances.html
@@ -54,14 +54,14 @@ function test()
function step4(newColumnState)
{
columns[currentColumn] = newColumnState;
- var columnName = columns[currentColumn].identifier;
+ var columnName = columns[currentColumn].id;
var row = InspectorTest.findRow("B");
InspectorTest.assertEquals(true, !!row, "\"B\" row");
var contents = row.children.map(function(obj) { return obj.element().children[currentColumn].textContent; });
InspectorTest.assertEquals(instanceCount, contents.length, "column contents");
var sortTypes = { object: "text", distance: "number", count: "number", shallowSize: "size", retainedSize: "size" };
- InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].identifier], "sort by identifier");
- InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[currentColumn].identifier], columns[currentColumn].sort);
+ InspectorTest.assertEquals(true, !!sortTypes[columns[currentColumn].id], "sort by id");
+ InspectorTest.checkArrayIsSorted(contents, sortTypes[columns[currentColumn].id], columns[currentColumn].sort);
if (!currentColumnOrder)
currentColumnOrder = true;

Powered by Google App Engine
This is Rietveld 408576698