third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js - Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)

Patch Set: changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/ResourceWebSocketFrameView.js » ('j') | third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

index f42cc41392b1c32bf8e21ba5db912315937742c0..7c004218d255ecd4e865b457d3a3022ded147b91 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

@@ -454,8 +454,8 @@ WebInspector.NetworkLogViewColumns.prototype = {

_sortHandler: function()

{

- var columnIdentifier = this._dataGrid.sortColumnIdentifier();

- var columnConfig = this._columns.find(columnConfig => columnConfig.id === columnIdentifier);

+ var columnId = this._dataGrid.sortColumnId();

+ var columnConfig = this._columns.find(columnConfig => columnConfig.id === columnId);

if (!columnConfig)

return;

if (columnConfig.sortConfig && columnConfig.sortConfig.entries) {