third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js - Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

Issue 2444223002: [Devtools] Cleanup DataGrid's typecast and identifier naming (Closed)

Patch Set: changes Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/EventSourceMessagesView.js ('k') | third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js » ('j') | third_party/WebKit/Source/devtools/front_end/resources/ApplicationCacheItemsView.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

index dd36b68cf14f4723147c7b634744bc9c69077c41..9de72e8f2865bbbea25513380ac1c4dd17e4a847 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js

@@ -1162,7 +1162,7 @@ WebInspector.NetworkLogView.prototype = {

this._timelineColumnSortIcon.classList.remove("sort-ascending", "sort-descending");

- if (this._dataGrid.sortColumnIdentifier() === "timeline") {

+ if (this._dataGrid.sortColumnId() === "timeline") {

if (this._dataGrid.sortOrder() === WebInspector.DataGrid.Order.Ascending)

this._timelineColumnSortIcon.classList.add("sort-ascending");

else