Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2444193009: LayoutState doesn't need to store both layout and pagination offset. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

LayoutState doesn't need to store both layout and pagination offset. We only ever used those two in combination to figure out how far away we were from the start of the pagination context. So, let's just store that directly instead. This allows us to clean up quite a bit. Also changed LayoutState() to do more early returns, when we have no more work left to do. Also consolidated two sections that disabled pagination for unsupported content (one for SVG and one for other unbreakable content). Committed: https://crrev.com/fb9e4782a189a3122fd7d313a1d3f8d6cae37076 Cr-Commit-Position: refs/heads/master@{#427945}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -69 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 3 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 3 chunks +40 lines, -56 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-26 22:35:11 UTC) #4
eae
LGTM
4 years, 1 month ago (2016-10-26 22:36:37 UTC) #5
mstensho (USE GERRIT)
On 2016/10/26 22:36:37, eae wrote: > LGTM Thanks. Fixed one typo in the commit message: ...
4 years, 1 month ago (2016-10-27 05:13:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2444193009/1
4 years, 1 month ago (2016-10-27 05:13:44 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 05:17:52 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fb9e4782a189a3122fd7d313a1d3f8d6cae37076 Cr-Commit-Position: refs/heads/master@{#427945}
4 years, 1 month ago (2016-10-27 05:20:18 UTC) #15
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-28 08:36:14 UTC) #16
Message was sent while issue was closed.
This fixed https://bugs.chromium.org/p/chromium/issues/detail?id=583713

Powered by Google App Engine
This is Rietveld 408576698