Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutState.h

Issue 2444193009: LayoutState doesn't need to store both layout and pagination offset. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007 Apple Inc. All rights reserved. 2 * Copyright (C) 2007 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 78 matching lines...) Expand 10 before | Expand all | Expand 10 after
89 LayoutUnit pageLogicalOffset(const LayoutBox&, 89 LayoutUnit pageLogicalOffset(const LayoutBox&,
90 const LayoutUnit& childLogicalOffset) const; 90 const LayoutUnit& childLogicalOffset) const;
91 91
92 LayoutUnit heightOffsetForTableHeaders() const { 92 LayoutUnit heightOffsetForTableHeaders() const {
93 return m_heightOffsetForTableHeaders; 93 return m_heightOffsetForTableHeaders;
94 }; 94 };
95 void setHeightOffsetForTableHeaders(LayoutUnit offset) { 95 void setHeightOffsetForTableHeaders(LayoutUnit offset) {
96 m_heightOffsetForTableHeaders = offset; 96 m_heightOffsetForTableHeaders = offset;
97 }; 97 };
98 98
99 const LayoutSize& layoutOffset() const { return m_layoutOffset; } 99 const LayoutSize& paginationOffset() const { return m_paginationOffset; }
100 const LayoutSize& pageOffset() const { return m_pageOffset; }
101 LayoutUnit pageLogicalHeight() const { return m_pageLogicalHeight; } 100 LayoutUnit pageLogicalHeight() const { return m_pageLogicalHeight; }
102 bool pageLogicalHeightChanged() const { return m_pageLogicalHeightChanged; } 101 bool pageLogicalHeightChanged() const { return m_pageLogicalHeightChanged; }
103 bool containingBlockLogicalWidthChanged() const { 102 bool containingBlockLogicalWidthChanged() const {
104 return m_containingBlockLogicalWidthChanged; 103 return m_containingBlockLogicalWidthChanged;
105 } 104 }
106 105
107 LayoutState* next() const { return m_next; } 106 LayoutState* next() const { return m_next; }
108 107
109 LayoutFlowThread* flowThread() const { return m_flowThread; } 108 LayoutFlowThread* flowThread() const { return m_flowThread; }
110 109
111 LayoutObject& layoutObject() const { return m_layoutObject; } 110 LayoutObject& layoutObject() const { return m_layoutObject; }
112 111
113 private: 112 private:
114 // Do not add anything apart from bitfields until after m_flowThread. See 113 // Do not add anything apart from bitfields until after m_flowThread. See
115 // https://bugs.webkit.org/show_bug.cgi?id=100173 114 // https://bugs.webkit.org/show_bug.cgi?id=100173
116 bool m_isPaginated : 1; 115 bool m_isPaginated : 1;
117 // If our page height has changed, this will force all blocks to relayout. 116 // If our page height has changed, this will force all blocks to relayout.
118 bool m_pageLogicalHeightChanged : 1; 117 bool m_pageLogicalHeightChanged : 1;
119 bool m_containingBlockLogicalWidthChanged : 1; 118 bool m_containingBlockLogicalWidthChanged : 1;
120 119
121 LayoutFlowThread* m_flowThread; 120 LayoutFlowThread* m_flowThread;
122 121
123 LayoutState* m_next; 122 LayoutState* m_next;
124 123
125 // x/y offset from container. Does not include relative positioning or scroll 124 // x/y offset from the logical top / start of the first page. Does not include
126 // offsets. 125 // relative positioning or scroll offsets.
127 LayoutSize m_layoutOffset; 126 LayoutSize m_paginationOffset;
128 127
129 // The current page height for the pagination model that encloses us. 128 // The current page height for the pagination model that encloses us.
130 LayoutUnit m_pageLogicalHeight; 129 LayoutUnit m_pageLogicalHeight;
131 130
132 // The height we need to make available for repeating table headers in 131 // The height we need to make available for repeating table headers in
133 // paginated layout. 132 // paginated layout.
134 LayoutUnit m_heightOffsetForTableHeaders; 133 LayoutUnit m_heightOffsetForTableHeaders;
135 134
136 // The offset of the start of the first page in the nearest enclosing
137 // pagination model.
138 LayoutSize m_pageOffset;
139
140 LayoutObject& m_layoutObject; 135 LayoutObject& m_layoutObject;
141 }; 136 };
142 137
143 } // namespace blink 138 } // namespace blink
144 139
145 #endif // LayoutState_h 140 #endif // LayoutState_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutBox.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutState.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698