Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2444193006: [inspector_protocol] pass inspector_protocol_dir to inspector_protocol_generate (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

[inspector_protocol] pass inspector_protocol_dir to inspector_protocol_generate I'm going to use different third_party folders for inspector_protocol in V8 and chromium: v8 - v8_inspector_protocol, chromium - inspector_protocol. It allows to have two different versions of protocol in chromium third_party. BUG=chromium:637032 R=dgozman@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocol6c15061ecf7168e520d33633b217e029e74760a7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M inspector_protocol.gni View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-10-26 00:15:44 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-10-26 01:50:54 UTC) #3
kozy
4 years, 1 month ago (2016-10-26 17:34:21 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6c15061ecf7168e520d33633b217e029e74760a7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698