Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: content/test/data/media/mediarecorder_test.html

Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever (Closed)
Patch Set: removed WebMediaRecorderHandler::start() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/test/data/media/mediarecorder_test.html
diff --git a/content/test/data/media/mediarecorder_test.html b/content/test/data/media/mediarecorder_test.html
index fa58e53950e9879895ffc9037b28436b823e1846..d6426b69e56ed7c61305379cb321ef9de4dc4b04 100644
--- a/content/test/data/media/mediarecorder_test.html
+++ b/content/test/data/media/mediarecorder_test.html
@@ -92,7 +92,7 @@ function createAndStartMediaRecorder(stream, mimeType, slice) {
recorder.start(slice);
console.log('Recorder started with time slice', slice);
} else {
- recorder.start();
+ recorder.start(1);
}
resolve(recorder);
});
@@ -106,7 +106,7 @@ function createMediaRecorder(stream, mimeType) {
});
}
-// Tests that the MediaRecorder's start() function will cause the |state| to be
+// Tests that the MediaRecorder's start(1) function will cause the |state| to be
// 'recording' and that a 'start' event is fired.
function testStartAndRecorderState() {
var startEventReceived = false;
@@ -120,7 +120,7 @@ function testStartAndRecorderState() {
startEventReceived = true;
assertEquals('recording', recorder.state);
};
- recorder.start();
+ recorder.start(1);
})
.then(function() {
return waitFor('Make sure the start event was received',
@@ -165,7 +165,7 @@ function testStartStopAndRecorderState() {
});
}
-// Tests that when MediaRecorder's start() function is called, some data is
+// Tests that when MediaRecorder's start(1) function is called, some data is
// made available by media recorder via dataavailable events, containing non
// empty blob data.
function testStartAndDataAvailable(codec) {
@@ -429,7 +429,7 @@ function testRecordRemotePeerConnection(codec) {
timeStamps.push(event.timeStamp);
videoSize += event.data.size;
};
- recorder.start();
+ recorder.start(1);
})
.then(function() {
return waitFor('Making sure the recording has data',
@@ -458,7 +458,7 @@ function testIllegalStopThrowsDOMError() {
});
}
-// Tests that MediaRecorder's start() throws an exception if |state| is
+// Tests that MediaRecorder's start(1) throws an exception if |state| is
// 'recording'.
function testIllegalStartInRecordingStateThrowsDOMError() {
navigator.mediaDevices.getUserMedia(DEFAULT_CONSTRAINTS)
@@ -466,12 +466,12 @@ function testIllegalStartInRecordingStateThrowsDOMError() {
return createAndStartMediaRecorder(stream, DEFAULT_RECORDER_MIME_TYPE);
})
.then(function(recorder) {
- assertThrows(function() {recorder.start()}, 'Calling start() in' +
+ assertThrows(function() {recorder.start(1)}, 'Calling start(1) in' +
' recording state should cause a DOM error');
});
}
-// Tests that MediaRecorder's start() throws an exception if |state| is
+// Tests that MediaRecorder's start(1) throws an exception if |state| is
// 'paused'.
function testIllegalStartInPausedStateThrowsDOMError() {
navigator.mediaDevices.getUserMedia(DEFAULT_CONSTRAINTS)
@@ -480,7 +480,7 @@ function testIllegalStartInPausedStateThrowsDOMError() {
})
.then(function(recorder) {
recorder.pause();
- assertThrows(function() {recorder.start()}, 'Calling start() in' +
+ assertThrows(function() {recorder.start(1)}, 'Calling start(1) in' +
' paused state should cause a DOM error');
});
}
@@ -500,7 +500,7 @@ function testTwoChannelAudio() {
recorder.ondataavailable = function(event) {
audioSize += event.data.size;
};
- recorder.start();
+ recorder.start(1);
oscillator.start();
context.startRendering();
})
@@ -547,7 +547,7 @@ function testAddingTrackToMediaStreamFiresErrorEvent() {
recorder.onerror = function(event) {
errorEventReceived = true;
};
- recorder.start();
+ recorder.start(1);
// Add a new track, copy of an existing one for simplicity.
theStream.addTrack(theStream.getTracks()[1].clone());
})
@@ -579,7 +579,7 @@ function testRemovingTrackFromMediaStreamFiresErrorEvent() {
recorder.onerror = function(event) {
errorEventReceived = true;
};
- recorder.start();
+ recorder.start(1);
theStream.removeTrack(theStream.getTracks()[1]);
})
.then(function() {

Powered by Google App Engine
This is Rietveld 408576698