Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Unified Diff: content/renderer/media/media_recorder_handler_unittest.cc

Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever (Closed)
Patch Set: removed WebMediaRecorderHandler::start() Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_recorder_handler_unittest.cc
diff --git a/content/renderer/media/media_recorder_handler_unittest.cc b/content/renderer/media/media_recorder_handler_unittest.cc
index 7ac1ebab90cf7887a7e1e68ea290406d289c7d87..735c6633760dda0202af9c6050ce8b9c5872f40a 100644
--- a/content/renderer/media/media_recorder_handler_unittest.cc
+++ b/content/renderer/media/media_recorder_handler_unittest.cc
@@ -197,7 +197,7 @@ TEST_P(MediaRecorderHandlerTest, InitializeStartStop) {
EXPECT_FALSE(hasVideoRecorders());
EXPECT_FALSE(hasAudioRecorders());
- EXPECT_TRUE(media_recorder_handler_->start());
+ EXPECT_TRUE(media_recorder_handler_->start(1));
EXPECT_TRUE(recording());
EXPECT_TRUE(hasVideoRecorders() || !GetParam().has_video);
@@ -225,7 +225,7 @@ TEST_P(MediaRecorderHandlerTest, EncodeVideoFrames) {
const WebString codecs(base::UTF8ToUTF16(GetParam().codecs));
EXPECT_TRUE(media_recorder_handler_->initialize(this, registry_.test_stream(),
mime_type, codecs, 0, 0));
- EXPECT_TRUE(media_recorder_handler_->start());
+ EXPECT_TRUE(media_recorder_handler_->start(1));
InSequence s;
const scoped_refptr<media::VideoFrame> video_frame =
@@ -286,7 +286,7 @@ TEST_P(MediaRecorderHandlerTest, EncodeAudioFrames) {
const WebString mime_type(base::UTF8ToUTF16("audio/webm"));
EXPECT_TRUE(media_recorder_handler_->initialize(
this, registry_.test_stream(), mime_type, WebString(), 0, 0));
- EXPECT_TRUE(media_recorder_handler_->start());
+ EXPECT_TRUE(media_recorder_handler_->start(1));
InSequence s;
const std::unique_ptr<media::AudioBus> audio_bus1 = NextAudioBus();

Powered by Google App Engine
This is Rietveld 408576698