Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Unified Diff: content/renderer/media/media_recorder_handler_unittest.cc

Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever (Closed)
Patch Set: s/start(1)/start(0)/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_recorder_handler.cc ('k') | content/test/data/media/mediarecorder_test.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_recorder_handler_unittest.cc
diff --git a/content/renderer/media/media_recorder_handler_unittest.cc b/content/renderer/media/media_recorder_handler_unittest.cc
index 7ac1ebab90cf7887a7e1e68ea290406d289c7d87..a582ac5e1615ed8f7735dc5b23404ea113d85a98 100644
--- a/content/renderer/media/media_recorder_handler_unittest.cc
+++ b/content/renderer/media/media_recorder_handler_unittest.cc
@@ -197,7 +197,7 @@ TEST_P(MediaRecorderHandlerTest, InitializeStartStop) {
EXPECT_FALSE(hasVideoRecorders());
EXPECT_FALSE(hasAudioRecorders());
- EXPECT_TRUE(media_recorder_handler_->start());
+ EXPECT_TRUE(media_recorder_handler_->start(0));
EXPECT_TRUE(recording());
EXPECT_TRUE(hasVideoRecorders() || !GetParam().has_video);
@@ -225,7 +225,7 @@ TEST_P(MediaRecorderHandlerTest, EncodeVideoFrames) {
const WebString codecs(base::UTF8ToUTF16(GetParam().codecs));
EXPECT_TRUE(media_recorder_handler_->initialize(this, registry_.test_stream(),
mime_type, codecs, 0, 0));
- EXPECT_TRUE(media_recorder_handler_->start());
+ EXPECT_TRUE(media_recorder_handler_->start(0));
InSequence s;
const scoped_refptr<media::VideoFrame> video_frame =
@@ -286,7 +286,7 @@ TEST_P(MediaRecorderHandlerTest, EncodeAudioFrames) {
const WebString mime_type(base::UTF8ToUTF16("audio/webm"));
EXPECT_TRUE(media_recorder_handler_->initialize(
this, registry_.test_stream(), mime_type, WebString(), 0, 0));
- EXPECT_TRUE(media_recorder_handler_->start());
+ EXPECT_TRUE(media_recorder_handler_->start(0));
InSequence s;
const std::unique_ptr<media::AudioBus> audio_bus1 = NextAudioBus();
« no previous file with comments | « content/renderer/media/media_recorder_handler.cc ('k') | content/test/data/media/mediarecorder_test.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698