content/renderer/media/media_recorder_handler.cc - Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/media_recorder_handler.cc

Issue 2444153002: MediaRecorder: bugfix start() means buffer-forever (Closed)

Patch Set: s/start(1)/start(0)/ Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/media/media_recorder_handler.cc

diff --git a/content/renderer/media/media_recorder_handler.cc b/content/renderer/media/media_recorder_handler.cc

index ead07c343937f9b295f8b5320dccf8379068bd3b..bba34682e8b8eb842697f28b3d9e165e828f2b28 100644

--- a/content/renderer/media/media_recorder_handler.cc

+++ b/content/renderer/media/media_recorder_handler.cc

@@ -140,12 +140,6 @@ bool MediaRecorderHandler::initialize(

return true;

}

-bool MediaRecorderHandler::start() {

- DCHECK(main_render_thread_checker_.CalledOnValidThread());

- DCHECK(!recording_);

- return start(0);

bool MediaRecorderHandler::start(int timeslice) {

DCHECK(main_render_thread_checker_.CalledOnValidThread());

DCHECK(!recording_);