Chromium Code Reviews| Index: components/metrics/proto/call_stack_profile.proto |
| diff --git a/components/metrics/proto/call_stack_profile.proto b/components/metrics/proto/call_stack_profile.proto |
| index e41b3390224ab8561f2285d7bd36217d990475ef..5e21c5f6be1fb985c001d52ce906f383abee506d 100644 |
| --- a/components/metrics/proto/call_stack_profile.proto |
| +++ b/components/metrics/proto/call_stack_profile.proto |
| @@ -12,6 +12,8 @@ option java_package = "org.chromium.components.metrics"; |
| package metrics; |
| +import "execution_context.proto"; |
| + |
| // Next tag: 5 |
| message CallStackProfile { |
| // Describes an entry in the callstack. |
| @@ -32,6 +34,20 @@ message CallStackProfile { |
| // Number of times this stack signature occurs. |
| optional int64 count = 2; |
| + |
| + // This repeating field indicates the current phase of the system such as |
| + // whether it is in startup, general operation, or shutdown. It is a full |
| + // list with the first sample and after that each indicates only the new |
| + // phases that are achieved. |
| + repeated ProcessPhase process_phase = 3; |
|
Alexei Svitkine (slow)
2016/11/07 23:22:07
This looks good to me!
I'm not sure about the act
bcwhite
2016/11/08 01:02:36
Acknowledged.
|
| + |
| + // These repeating fields provide information about current activities of |
| + // the system such as whether it is (for example) writing out profile |
| + // information or uploading metrics. The first sample will indicate all |
| + // activities that had previously started and after that each activity that |
| + // began or ended since the previous sample. |
| + repeated ProcessActivity activity_begun = 4; |
| + repeated ProcessActivity activity_ended = 5; |
| } |
| // Uniquely identifies a module. |