Add process lifetime annotations to stack samples.

components/metrics/proto/call_stack_profile.proto

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Call stack sample data for a given profiling session.
 
 syntax = "proto2";
 
 option optimize_for = LITE_RUNTIME;
 option java_outer_classname = "CallStackProfileProtos";
 option java_package = "org.chromium.components.metrics";
 
 package metrics;
 
+import "execution_context.proto";
+
 // Next tag: 5
 message CallStackProfile {
   // Describes an entry in the callstack.
   message Entry {
     // Instruction pointer subtracted by module base.
     optional uint64 address = 1;
 
     // Index to the module identifier in |module_ids| of CallStackProfile.
     optional int32 module_id_index = 2;
   }
 
   // A sample consisting of one or more callstacks with the same stack frames
   // and instruction pointers.
   message Sample {
     // The callstack. Sample.entries[0] represents the call on the top of the
     // stack.
     repeated Entry entry = 1;
 
     // Number of times this stack signature occurs.
     optional int64 count = 2;
+
+    // This repeating field indicates the current phase of the system such as
+    // whether it is in startup, general operation, or shutdown. It is a full
+    // list with the first sample and after that each indicates only the new
+    // phases that are achieved.
+    repeated ProcessPhase process_phase = 3;

[Alexei Svitkine (slow), 2016/11/07 23:22:07]

This looks good to me!

I'm not sure about the activities part - so we can chat offline or you can
remove it from the CL for now. Whichever we do, we'll need to land the
server-side version of this proto change before submitting this CL.

[bcwhite, 2016/11/08 01:02:36]

Acknowledged.

+
+    // These repeating fields provide information about current activities of
+    // the system such as whether it is (for example) writing out profile
+    // information or uploading metrics. The first sample will indicate all
+    // activities that had previously started and after that each activity that
+    // began or ended since the previous sample.
+    repeated ProcessActivity activity_begun = 4;
+    repeated ProcessActivity activity_ended = 5;
   }
 
   // Uniquely identifies a module.
   message ModuleIdentifier {
     // A hash that uniquely identifies a particular program version with high
     // probability. This is parsed from headers of the loaded module.
     // For binaries generated by GNU tools:
     //   Contents of the .note.gnu.build-id field.
     // On Windows:
     //   GUID + AGE in the debug image headers of a module.
     optional string build_id = 1;
 
     // MD5Sum Prefix of the module name. This is the same hashing scheme as used
     // to hash UMA histogram names.
     optional fixed64 name_md5_prefix = 2;
   }
 
   // The callstack and counts.
   repeated Sample sample = 1;
 
   // List of module ids found in this sample.
   repeated ModuleIdentifier module_id = 2;
 
   // Duration of this profile.
   optional int32 profile_duration_ms = 3;
 
   // Time between samples.
   optional int32 sampling_period_ms = 4;
 }