Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2443883002: Use DEFINE_TRACE in FrameSelection instead of DEFINE_VIRTUAL_TRACE (Closed)

Created:
4 years, 2 months ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use DEFINE_TRACE in FrameSelection instead of DEFINE_VIRTUAL_TRACE This patch changes |FrameSelection| class to use |DEFINE_TRACE()| instead of |DEFINE_VIRTUAL_TRACE()| since |FrameSelection| is final. |DEFINE_VIRTUAL_TRACE()| was introduced by [1] as result of mechanical replacing of |virtual void trace()|. [1] https://chromium.googlesource.com/chromium/src/+/0ae5a4a2770e78d7cdc0025f1ebeebd797691b16 BUG=n/a TEST=n/a; no behavior changes. Committed: https://crrev.com/b80ad15447c25b8af821a851961ce078d9c2d042 Cr-Commit-Position: refs/heads/master@{#427030}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
yosin_UTC9
PTAL
4 years, 2 months ago (2016-10-24 08:20:34 UTC) #6
tkent
lgtm. Probably it is virtual because FrameSelection inherited from CaretBase.
4 years, 2 months ago (2016-10-24 08:23:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443883002/1
4 years, 2 months ago (2016-10-24 08:24:26 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 09:21:47 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 09:23:59 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b80ad15447c25b8af821a851961ce078d9c2d042
Cr-Commit-Position: refs/heads/master@{#427030}

Powered by Google App Engine
This is Rietveld 408576698