Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2443883002: Use DEFINE_TRACE in FrameSelection instead of DEFINE_VIRTUAL_TRACE (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 272 matching lines...) Expand 10 before | Expand all | Expand 10 after
283 283
284 bool shouldShowBlockCursor() const; 284 bool shouldShowBlockCursor() const;
285 void setShouldShowBlockCursor(bool); 285 void setShouldShowBlockCursor(bool);
286 286
287 // TODO(yosin): We should check DOM tree version and style version in 287 // TODO(yosin): We should check DOM tree version and style version in
288 // |FrameSelection::selection()| to make sure we use updated selection, 288 // |FrameSelection::selection()| to make sure we use updated selection,
289 // rather than having |updateIfNeeded()|. Once, we update all layout tests 289 // rather than having |updateIfNeeded()|. Once, we update all layout tests
290 // to use updated selection, we should make |updateIfNeeded()| private. 290 // to use updated selection, we should make |updateIfNeeded()| private.
291 void updateIfNeeded(); 291 void updateIfNeeded();
292 292
293 DECLARE_VIRTUAL_TRACE(); 293 DECLARE_TRACE();
294 294
295 private: 295 private:
296 friend class FrameSelectionTest; 296 friend class FrameSelectionTest;
297 friend class PaintControllerPaintTestForSlimmingPaintV1AndV2; 297 friend class PaintControllerPaintTestForSlimmingPaintV1AndV2;
298 FRIEND_TEST_ALL_PREFIXES(PaintControllerPaintTestForSlimmingPaintV1AndV2, 298 FRIEND_TEST_ALL_PREFIXES(PaintControllerPaintTestForSlimmingPaintV1AndV2,
299 FullDocumentPaintingWithCaret); 299 FullDocumentPaintingWithCaret);
300 300
301 explicit FrameSelection(LocalFrame*); 301 explicit FrameSelection(LocalFrame*);
302 302
303 // Note: We have |selectionInFlatTree()| for unit tests, we should 303 // Note: We have |selectionInFlatTree()| for unit tests, we should
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
374 } 374 }
375 } // namespace blink 375 } // namespace blink
376 376
377 #ifndef NDEBUG 377 #ifndef NDEBUG
378 // Outside the WebCore namespace for ease of invocation from gdb. 378 // Outside the WebCore namespace for ease of invocation from gdb.
379 void showTree(const blink::FrameSelection&); 379 void showTree(const blink::FrameSelection&);
380 void showTree(const blink::FrameSelection*); 380 void showTree(const blink::FrameSelection*);
381 #endif 381 #endif
382 382
383 #endif // FrameSelection_h 383 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698