Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 2443873002: Remove bitfields in Resource used for storing enum values (Closed)

Created:
4 years, 2 months ago by hiroshige
Modified:
4 years, 1 month ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove bitfields in Resource used for storing enum values BUG= Committed: https://crrev.com/b86cffd64bddbf6af13c841d7f6bc2c0c3734388 Cr-Commit-Position: refs/heads/master@{#427041}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M third_party/WebKit/Source/core/fetch/Resource.h View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/fetch/Resource.cpp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
hiroshige
PTAL.
4 years, 1 month ago (2016-10-24 10:32:15 UTC) #6
yhirano
lgtm
4 years, 1 month ago (2016-10-24 10:34:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443873002/1
4 years, 1 month ago (2016-10-24 10:49:13 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 11:07:22 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 11:13:06 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b86cffd64bddbf6af13c841d7f6bc2c0c3734388
Cr-Commit-Position: refs/heads/master@{#427041}

Powered by Google App Engine
This is Rietveld 408576698