Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 2443873002: Remove bitfields in Resource used for storing enum values (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/fetch/Resource.h
diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h
index 86e6185daaabdce9fe726b664f7f41baedc58afe..151249c53204d42bd83572b89d8d919e2ce593e3 100644
--- a/third_party/WebKit/Source/core/fetch/Resource.h
+++ b/third_party/WebKit/Source/core/fetch/Resource.h
@@ -161,11 +161,9 @@ class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource>,
PreloadReferencedWhileLoading,
PreloadReferencedWhileComplete
};
- PreloadResult getPreloadResult() const {
- return static_cast<PreloadResult>(m_preloadResult);
- }
+ PreloadResult getPreloadResult() const { return m_preloadResult; }
- Status getStatus() const { return static_cast<Status>(m_status); }
+ Status getStatus() const { return m_status; }
void setStatus(Status status) { m_status = status; }
size_t size() const { return encodedSize() + decodedSize() + overheadSize(); }
@@ -434,9 +432,9 @@ class CORE_EXPORT Resource : public GarbageCollectedFinalized<Resource>,
String m_cacheIdentifier;
- unsigned m_preloadResult : 2; // PreloadResult
- unsigned m_type : 4; // Type
- unsigned m_status : 3; // Status
+ PreloadResult m_preloadResult;
+ Type m_type;
+ Status m_status;
bool m_needsSynchronousCacheHit;
bool m_linkPreload;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698