Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: Source/testing/runner/TestRunner.cpp

Issue 24438004: Rename testRunner.dumpAsText(true) to testRunner.dumpAsTextWithPixelResults() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: more tests Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/testing/runner/TestRunner.h ('k') | Tools/Scripts/bencher » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/testing/runner/TestRunner.cpp
diff --git a/Source/testing/runner/TestRunner.cpp b/Source/testing/runner/TestRunner.cpp
index d13a7b6a16000d7d272b78c24bf5e6da71a7ec30..716a66ada81b39ca3262c2abc917be1828fe6ed6 100644
--- a/Source/testing/runner/TestRunner.cpp
+++ b/Source/testing/runner/TestRunner.cpp
@@ -229,6 +229,7 @@ TestRunner::TestRunner(TestInterfaces* interfaces)
// The following modify the state of the TestRunner.
bindMethod("dumpEditingCallbacks", &TestRunner::dumpEditingCallbacks);
bindMethod("dumpAsText", &TestRunner::dumpAsText);
+ bindMethod("dumpAsTextWithPixelResults", &TestRunner::dumpAsTextWithPixelResults);
bindMethod("dumpChildFramesAsText", &TestRunner::dumpChildFramesAsText);
bindMethod("dumpChildFrameScrollPositions", &TestRunner::dumpChildFrameScrollPositions);
bindMethod("dumpIconChanges", &TestRunner::dumpIconChanges);
@@ -1948,14 +1949,18 @@ void TestRunner::dumpEditingCallbacks(const CppArgumentList&, CppVariant* result
result->setNull();
}
-void TestRunner::dumpAsText(const CppArgumentList& arguments, CppVariant* result)
+void TestRunner::dumpAsText(const CppArgumentList&, CppVariant* result)
{
m_dumpAsText = true;
m_generatePixelResults = false;
- // Optional paramater, describing whether it's allowed to dump pixel results in dumpAsText mode.
- if (arguments.size() > 0 && arguments[0].isBool())
- m_generatePixelResults = arguments[0].value.boolValue;
+ result->setNull();
+}
+
+void TestRunner::dumpAsTextWithPixelResults(const CppArgumentList&, CppVariant* result)
+{
+ m_dumpAsText = true;
+ m_generatePixelResults = true;
result->setNull();
}
« no previous file with comments | « Source/testing/runner/TestRunner.h ('k') | Tools/Scripts/bencher » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698