Tools/Scripts/bencher - Issue 24438004: Rename testRunner.dumpAsText(true) to testRunner.dumpAsTextWithPixelResults()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/bencher

Issue 24438004: Rename testRunner.dumpAsText(true) to testRunner.dumpAsTextWithPixelResults() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: more tests Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Tools/Scripts/bencher

diff --git a/Tools/Scripts/bencher b/Tools/Scripts/bencher

index 3ef504e59e9b0fe426cd4fc447aa82ac56714a7c..91832626f5b3915468a638a374ae89dfa116aaba 100755

--- a/Tools/Scripts/bencher

+++ b/Tools/Scripts/bencher

@@ -718,8 +718,11 @@ def emitBenchRunCodeFile(name, plan, benchDataPath, benchPath)

preCode = Benchfile.create("bencher-pre") {

| file |

doublePuts($stderr,file,"if (window.testRunner) {")

- doublePuts($stderr,file," testRunner.dumpAsText(window.enablePixelTesting);")

- doublePuts($stderr,file," testRunner.waitUntilDone();")

+ doublePuts($stderr,file," if (window.enablePixelTesting) {")

+ doublePuts($stderr,file," testRunner.dumpAsTextWithPixelResults();")

+ doublePuts($stderr,file," } else {")

+ doublePuts($stderr,file," testRunner.dumpAsText();")

+ doublePuts($stderr,file," }")

doublePuts($stderr,file,"}")

doublePuts($stderr,file,"")

doublePuts($stderr,file,"function debug(msg)")

« no previous file with comments | « Source/testing/runner/TestRunner.cpp ('k') | no next file » | no next file with comments »