Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(477)

Issue 24436002: Remove screen dimensions from image sent with Feedback. (Closed)

Created:
7 years, 3 months ago by rkc
Modified:
7 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, ben+watch_chromium.org, sadrul, extensions-reviews_chromium.org, pkotwicz
Visibility:
Public.

Description

Remove screen dimensions from image sent with Feedback. After speaking with the engineers on the feedback backend, I confirmed that the screen dimensions we send are ignored and instead the dimensions are pulled from the image itself. Hence this CL removes the dimensions and replaces them with a placeholder value (so that the protobuf to remain valid - without any dimensions, the server won't accept the report). This accomplishes two things, first, the hack we put in place to 'remember' the screen dimensions associated with a feedback report can now be removed. second, not requiring a browser for dimenions makes it simple to deal with the case where feedback can be invoked without a browser (as referred to in the crbug for this CL). R=asargent@chromium.org, jamescook@chromium.org, zork@chromium.org BUG=297334 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225275

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -79 lines) Patch
M chrome/browser/extensions/api/feedback_private/feedback_private_api.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/api/feedback_private/feedback_private_api.cc View 1 2 chunks +1 line, -9 lines 0 comments Download
M chrome/browser/feedback/feedback_data.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_data.cc View 2 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/feedback/feedback_util.cc View 1 6 chunks +26 lines, -50 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/ui/ash/chrome_shell_delegate.cc View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
rkc
7 years, 3 months ago (2013-09-24 21:25:10 UTC) #1
rkc
jamescook@ for OWNERS review on chrome/browser/ui/ash/
7 years, 3 months ago (2013-09-24 21:34:38 UTC) #2
James Cook
c/b/ui/ash lgtm +pkotwicz fyi
7 years, 3 months ago (2013-09-24 21:36:20 UTC) #3
asargent_no_longer_on_chrome
extensions parts LGTM
7 years, 3 months ago (2013-09-24 23:22:56 UTC) #4
Zachary Kuznia
lgtm https://codereview.chromium.org/24436002/diff/1/chrome/browser/feedback/feedback_util.cc File chrome/browser/feedback/feedback_util.cc (right): https://codereview.chromium.org/24436002/diff/1/chrome/browser/feedback/feedback_util.cc#newcode227 chrome/browser/feedback/feedback_util.cc:227: const std::string& description_template, nit: fix this indent while ...
7 years, 3 months ago (2013-09-24 23:46:43 UTC) #5
rkc
https://codereview.chromium.org/24436002/diff/1/chrome/browser/feedback/feedback_util.cc File chrome/browser/feedback/feedback_util.cc (right): https://codereview.chromium.org/24436002/diff/1/chrome/browser/feedback/feedback_util.cc#newcode227 chrome/browser/feedback/feedback_util.cc:227: const std::string& description_template, On 2013/09/24 23:46:43, Zachary Kuznia wrote: ...
7 years, 3 months ago (2013-09-25 00:00:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/24436002/9001
7 years, 3 months ago (2013-09-25 00:13:03 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) content_browsertests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=171552
7 years, 3 months ago (2013-09-25 02:29:38 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/24436002/9001
7 years, 2 months ago (2013-09-25 18:45:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rkc@chromium.org/24436002/9001
7 years, 2 months ago (2013-09-25 21:48:00 UTC) #10
rkc
7 years, 2 months ago (2013-09-25 23:14:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 manually as r225275 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698