Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(988)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc

Issue 24436002: Remove screen dimensions from image sent with Feedback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
index eeb263bfa7240362c3ade638e23ba323d1b26ab8..e9d0c7dce91929e30c137f4ea5efc4d196170c24 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.cc
@@ -51,8 +51,7 @@ FeedbackService* FeedbackPrivateAPI::GetService() const {
void FeedbackPrivateAPI::RequestFeedback(
const std::string& description_template,
const std::string& category_tag,
- const GURL& page_url,
- const gfx::Rect& screen_size) {
+ const GURL& page_url) {
if (profile_ && ExtensionSystem::Get(profile_)->event_router()) {
FeedbackInfo info;
info.description = description_template;
@@ -64,13 +63,6 @@ void FeedbackPrivateAPI::RequestFeedback(
info.trace_id.reset(new int(manager->RequestTrace()));
}
- FeedbackService::PopulateSystemInfo(
- info.system_information.get(), FeedbackData::kScreensizeHeightKey,
- base::IntToString(screen_size.height()));
- FeedbackService::PopulateSystemInfo(
- info.system_information.get(), FeedbackData::kScreensizeWidthKey,
- base::IntToString(screen_size.width()));
-
scoped_ptr<base::ListValue> args(new base::ListValue());
args->Append(info.ToValue().release());
« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_private_api.h ('k') | chrome/browser/feedback/feedback_data.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698