third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h - Issue 2443543002: createElement should not transmit exceptions but report them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2443543002: createElement should not transmit exceptions but report them. (Closed)

Patch Set: Rebaseline tests. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/custom/CustomElement.cpp ('k') | third_party/WebKit/Source/core/dom/custom/CustomElementTestHelpers.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

diff --git a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

index 8a0929225e72fd3ebc23300baf6454a2f8724477..2717cadb32133f036aea21f3d1184526039b5d9b 100644

--- a/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

+++ b/third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

@@ -49,9 +49,6 @@ class CORE_EXPORT CustomElementDefinition

HTMLElement* createElementForConstructor(Document&);

virtual HTMLElement* createElementSync(Document&, const QualifiedName&) = 0;

- virtual HTMLElement* createElementSync(Document&,

- const QualifiedName&,

- ExceptionState&) = 0;

HTMLElement* createElementAsync(Document&, const QualifiedName&);

void upgrade(Element*);