Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Side by Side Diff: third_party/WebKit/Source/core/dom/custom/CustomElementDefinition.h

Issue 2443543002: createElement should not transmit exceptions but report them. (Closed)
Patch Set: Rebaseline tests. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CustomElementDefinition_h 5 #ifndef CustomElementDefinition_h
6 #define CustomElementDefinition_h 6 #define CustomElementDefinition_h
7 7
8 #include "bindings/core/v8/ScriptValue.h" 8 #include "bindings/core/v8/ScriptValue.h"
9 #include "core/CoreExport.h" 9 #include "core/CoreExport.h"
10 #include "core/dom/custom/CustomElementDescriptor.h" 10 #include "core/dom/custom/CustomElementDescriptor.h"
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
42 // |CustomElementConstructor| to |ScriptValue|. Replace 42 // |CustomElementConstructor| to |ScriptValue|. Replace
43 // |getConstructorForScript()| by |getConstructor() -> 43 // |getConstructorForScript()| by |getConstructor() ->
44 // CustomElementConstructor|. 44 // CustomElementConstructor|.
45 virtual ScriptValue getConstructorForScript() = 0; 45 virtual ScriptValue getConstructorForScript() = 0;
46 46
47 using ConstructionStack = HeapVector<Member<Element>, 1>; 47 using ConstructionStack = HeapVector<Member<Element>, 1>;
48 ConstructionStack& constructionStack() { return m_constructionStack; } 48 ConstructionStack& constructionStack() { return m_constructionStack; }
49 49
50 HTMLElement* createElementForConstructor(Document&); 50 HTMLElement* createElementForConstructor(Document&);
51 virtual HTMLElement* createElementSync(Document&, const QualifiedName&) = 0; 51 virtual HTMLElement* createElementSync(Document&, const QualifiedName&) = 0;
52 virtual HTMLElement* createElementSync(Document&,
53 const QualifiedName&,
54 ExceptionState&) = 0;
55 HTMLElement* createElementAsync(Document&, const QualifiedName&); 52 HTMLElement* createElementAsync(Document&, const QualifiedName&);
56 53
57 void upgrade(Element*); 54 void upgrade(Element*);
58 55
59 virtual bool hasConnectedCallback() const = 0; 56 virtual bool hasConnectedCallback() const = 0;
60 virtual bool hasDisconnectedCallback() const = 0; 57 virtual bool hasDisconnectedCallback() const = 0;
61 virtual bool hasAdoptedCallback() const = 0; 58 virtual bool hasAdoptedCallback() const = 0;
62 bool hasAttributeChangedCallback(const QualifiedName&) const; 59 bool hasAttributeChangedCallback(const QualifiedName&) const;
63 bool hasStyleAttributeChangedCallback() const; 60 bool hasStyleAttributeChangedCallback() const;
64 61
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
108 ConstructionStack m_constructionStack; 105 ConstructionStack m_constructionStack;
109 HashSet<AtomicString> m_observedAttributes; 106 HashSet<AtomicString> m_observedAttributes;
110 bool m_hasStyleAttributeChangedCallback; 107 bool m_hasStyleAttributeChangedCallback;
111 108
112 void enqueueAttributeChangedCallbackForAllAttributes(Element*); 109 void enqueueAttributeChangedCallbackForAllAttributes(Element*);
113 }; 110 };
114 111
115 } // namespace blink 112 } // namespace blink
116 113
117 #endif // CustomElementDefinition_h 114 #endif // CustomElementDefinition_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698