Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2443343002: Make shelf risk description strings match download page strings (Closed)

Created:
4 years, 1 month ago by Jialiu Lin
Modified:
4 years, 1 month ago
Reviewers:
grt (UTC plus 2)
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make shelf risk description strings match download page strings BUG=657522 Committed: https://crrev.com/ab5c4fa44e1a46c0749b4f1f9c65688fce045137 Cr-Commit-Position: refs/heads/master@{#427391}

Patch Set 1 #

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M chrome/app/chromium_strings.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/google_chrome_strings.grd View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Jialiu Lin
Hi grt@, Since you've reviewed string changes in https://codereview.chromium.org/2314903003/, this is a follow-up CL to ...
4 years, 1 month ago (2016-10-24 18:54:53 UTC) #2
grt (UTC plus 2)
lgtm
4 years, 1 month ago (2016-10-25 10:59:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443343002/20001
4 years, 1 month ago (2016-10-25 17:03:39 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-25 17:26:02 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 17:37:04 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ab5c4fa44e1a46c0749b4f1f9c65688fce045137
Cr-Commit-Position: refs/heads/master@{#427391}

Powered by Google App Engine
This is Rietveld 408576698