webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc - Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc

Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc

diff --git a/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc b/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc

index 63be85afdcabfd379fe11bad9b739d9a203fa28a..3144b5ffb88793c759f9e96283a7c19fa45824e7 100644

--- a/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc

+++ b/webrtc/modules/video_coding/codecs/vp8/test/vp8_impl_unittest.cc

@@ -110,7 +110,7 @@ bool Vp8UnitTestDecodeCompleteCallback::DecodeComplete() {

}

int Vp8UnitTestDecodeCompleteCallback::Decoded(VideoFrame& image) {

- decoded_frame_->ShallowCopy(image);

+ *decoded_frame_ = image;

decode_complete = true;

return 0;

}