webrtc/common_video/video_frame.cc - Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/common_video/video_frame.cc

Issue 2443123002: Delete ShallowCopy, in favor of copy construction and assignment. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/common_video/video_frame.cc

diff --git a/webrtc/common_video/video_frame.cc b/webrtc/common_video/video_frame.cc

index 7145a623e65ef4837c7b216b528ae1575254506a..ebff2a9987bdab1f656e622cf436b55870fc6946 100644

--- a/webrtc/common_video/video_frame.cc

+++ b/webrtc/common_video/video_frame.cc

@@ -94,11 +94,7 @@ void VideoFrame::CreateFrame(const uint8_t* buffer,

}

void VideoFrame::ShallowCopy(const VideoFrame& videoFrame) {

tommi 2016/10/24 10:52:17 change variable name to video_frame? (or even just

nisse-chromium (ooo August 14) 2016/10/24 11:01:20 Done.

- video_frame_buffer_ = videoFrame.video_frame_buffer();

- timestamp_rtp_ = videoFrame.timestamp_rtp_;

- ntp_time_ms_ = videoFrame.ntp_time_ms_;

- timestamp_us_ = videoFrame.timestamp_us_;

- rotation_ = videoFrame.rotation_;

+ *this = videoFrame;

}

int VideoFrame::width() const {