Remove unused include in sequenced_worker_pool.h

content/browser/loader/upload_data_stream_builder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/loader/upload_data_stream_builder.h"
 
 #include <stdint.h>
 
 #include <limits>
 #include <utility>
 #include <vector>
 
 #include "base/logging.h"
 #include "base/macros.h"
 #include "base/memory/ptr_util.h"
 #include "base/memory/ref_counted.h"
+#include "base/single_thread_task_runner.h"

[Charlie Harrison, 2016/11/01 02:53:35]

I'm not sure why this can't be a fwd-decl. There's no use of
scoped_refptr<SingleThreadTaskRunner> in the header.

[gab, 2016/11/01 13:30:58]

It's subtle but there is, in UploadDataStreamBuilder::Build():
|file_task_runner| is passed into FileElementReader's constructor. The former is
a SingleThreadTaskRunner* while the latter takes a TaskRunner* as argument. In
order to perform the implicit upcast, the compiler has to know that
SingleThreadTaskRunner implements TaskRunner.

 #include "content/browser/fileapi/upload_file_system_file_element_reader.h"
 #include "content/common/resource_request_body_impl.h"
 #include "net/base/elements_upload_data_stream.h"
 #include "net/base/upload_bytes_element_reader.h"
 #include "net/base/upload_file_element_reader.h"
 #include "storage/browser/blob/blob_data_handle.h"
 #include "storage/browser/blob/blob_reader.h"
 #include "storage/browser/blob/blob_storage_context.h"
 #include "storage/browser/blob/upload_blob_element_reader.h"
 
+namespace base {
+class TaskRunner;
+}
+
 namespace disk_cache {
 class Entry;
 }
 
 namespace content {
 namespace {
 
 // A subclass of net::UploadBytesElementReader which owns
 // ResourceRequestBodyImpl.
 class BytesElementReader : public net::UploadBytesElementReader {
@@ skipping 82 matching lines @@
         NOTREACHED();
         break;
     }
   }
 
   return base::MakeUnique<net::ElementsUploadDataStream>(
       std::move(element_readers), body->identifier());
 }
 
 }  // namespace content