Issue 2443103002: service worker: Implement NavigationPreloadManager.getState

falken

The CQ bit was checked by falken@chromium.org to run a CQ dry run

4 years, 2 months ago (2016-10-24 08:21:54 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443103002/1

4 years, 2 months ago (2016-10-24 08:22:08 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-24 10:05:15 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/317573)

4 years, 1 month ago (2016-10-24 10:05:15 UTC) #4

falken

The CQ bit was checked by falken@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-25 06:58:05 UTC) #7

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443103002/40001

4 years, 1 month ago (2016-10-25 06:58:21 UTC) #8

horo

lgtm with nits https://codereview.chromium.org/2443103002/diff/40001/third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html (right): https://codereview.chromium.org/2443103002/diff/40001/third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html#newcode1 third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html:1: <!DOCTYPE html> Nit: Why are you ...

4 years, 1 month ago (2016-10-25 07:51:47 UTC) #9

falken

Thank you. https://codereview.chromium.org/2443103002/diff/40001/third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html File third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html (right): https://codereview.chromium.org/2443103002/diff/40001/third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html#newcode1 third_party/WebKit/LayoutTests/http/tests/serviceworker/navigation-preload/getState.html:1: <!DOCTYPE html> On 2016/10/25 07:51:47, horo wrote: ...

4 years, 1 month ago (2016-10-25 08:06:29 UTC) #10

falken

falken@chromium.org changed reviewers: + nasko@chromium.org, rkaplow@chromium.org, tkent@chromium.org

4 years, 1 month ago (2016-10-25 08:08:02 UTC) #11

falken

OWNERS please review: - nasko: bad_message.h and service_worker_messages.h - rkaplow: histograms - tkent: public/BUILD.gn

4 years, 1 month ago (2016-10-25 08:08:03 UTC) #12

falken

The CQ bit was checked by falken@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-25 08:08:21 UTC) #13

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443103002/80001

4 years, 1 month ago (2016-10-25 08:08:37 UTC) #14

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-25 08:57:15 UTC) #15

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/321573)

4 years, 1 month ago (2016-10-25 08:57:16 UTC) #16

rkaplow

https://codereview.chromium.org/2443103002/diff/80001/content/browser/bad_message.h File content/browser/bad_message.h (right): https://codereview.chromium.org/2443103002/diff/80001/content/browser/bad_message.h#newcode170 content/browser/bad_message.h:170: SWDH_GET_NAVIGATION_PRELOAD_STATE_NO_HOST = 143, you're duplicating ids here

4 years, 1 month ago (2016-10-25 15:30:16 UTC) #17

tkent

On 2016/10/25 at 08:08:03, falken wrote: > OWNERS please review: > - tkent: public/BUILD.gn lgtm. ...

4 years, 1 month ago (2016-10-25 23:01:53 UTC) #18

nasko

https://codereview.chromium.org/2443103002/diff/80001/content/browser/service_worker/service_worker_dispatcher_host.cc File content/browser/service_worker/service_worker_dispatcher_host.cc (right): https://codereview.chromium.org/2443103002/diff/80001/content/browser/service_worker/service_worker_dispatcher_host.cc#newcode767 content/browser/service_worker/service_worker_dispatcher_host.cc:767: this, bad_message::SWDH_ENABLE_NAVIGATION_PRELOAD_BAD_REGISTRATION_ID); Shouldn't this be SWDH_GET_NAVIGATION_PRELOAD_STATE_BAD_REGISTRATION_ID?

4 years, 1 month ago (2016-10-25 23:23:42 UTC) #19

falken

Thanks. Fixed bad copy/paste coding and the test expectations for virtual mojo-service-worker. https://codereview.chromium.org/2443103002/diff/80001/content/browser/bad_message.h File content/browser/bad_message.h ...

4 years, 1 month ago (2016-10-25 23:55:58 UTC) #21

falken

The CQ bit was checked by falken@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-25 23:56:12 UTC) #22

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443103002/120001

4 years, 1 month ago (2016-10-25 23:56:36 UTC) #23

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-25 23:58:35 UTC) #24

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/93718) ios-simulator on ...

4 years, 1 month ago (2016-10-25 23:58:36 UTC) #25

falken

The CQ bit was checked by falken@chromium.org to run a CQ dry run

4 years, 1 month ago (2016-10-26 00:25:10 UTC) #27

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443103002/180001

4 years, 1 month ago (2016-10-26 00:25:37 UTC) #28

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

4 years, 1 month ago (2016-10-26 02:24:47 UTC) #29

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/324401)

4 years, 1 month ago (2016-10-26 02:24:48 UTC) #30

falken

The patchset sent to the CQ was uploaded after l-g-t-m from horo@chromium.org, tkent@chromium.org, nasko@chromium.org Link ...

4 years, 1 month ago (2016-10-26 03:12:27 UTC) #33

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2443103002/180001

4 years, 1 month ago (2016-10-26 03:12:47 UTC) #34

commit-bot: I haz the power

Description was changed from ========== service worker: Implement NavigationPreloadManager.getState BUG=649558 ========== to ========== service worker: ...

4 years, 1 month ago (2016-10-26 05:31:57 UTC) #36

commit-bot: I haz the power

4 years, 1 month ago (2016-10-26 05:31:58 UTC) #37

Message was sent while issue was closed.

Patchset 9 (id:??) landed as
https://crrev.com/b49387a112b13eb4ed99810b4c2c094299d4a4fd
Cr-Commit-Position: refs/heads/master@{#427596}

Issue 2443103002: service worker: Implement NavigationPreloadManager.getState (Closed)

Description

Patch Set 1 #

Patch Set 2 : test #

Patch Set 3 : reject #

Patch Set 4 : comments #

Patch Set 5 : update histograms #

Patch Set 6 : comments #

Patch Set 7 : ...and rebase #

Patch Set 8 : ... and update_bad_message_reasons #

Patch Set 9 : rm file added in bad merge #

Messages