Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2206)

Unified Diff: cc/output/context_provider.h

Issue 2443003004: cc: Make OutputSurface::BindToClient pure virtual and not return bool (Closed)
Patch Set: bindtoclient-pure-virtual: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/BUILD.gn ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/output/context_provider.h
diff --git a/cc/output/context_provider.h b/cc/output/context_provider.h
index 0c1310b2ef66d8fb3610ea8f9965004b333be64e..e6e8e95a2d45b1b75dd5672d1bad2f9a256535e6 100644
--- a/cc/output/context_provider.h
+++ b/cc/output/context_provider.h
@@ -74,6 +74,10 @@ class ContextProvider : public base::RefCountedThreadSafe<ContextProvider> {
// Sets a callback to be called when the context is lost. This should be
// called from the same thread that the context is bound to. To avoid races,
// it should be called before BindToCurrentThread().
+ // Implementation note: Implementations must avoid post-tasking the provided
+ // |lost_context_callback| directly as clients expect the method to not be
+ // called once they call SetLostContextCallback() again with a different
+ // callback.
typedef base::Closure LostContextCallback;
virtual void SetLostContextCallback(
const LostContextCallback& lost_context_callback) = 0;
« no previous file with comments | « cc/BUILD.gn ('k') | cc/output/gl_renderer_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698