Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2442963002: Remove GpuRasterization.BlueBox suppression for Win/AMD. (Closed)

Created:
4 years, 2 months ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 2 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, jam, darin-cc_chromium.org, piman+watch_chromium.org, ericrk
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GpuRasterization.BlueBox suppression for Win/AMD. GPU rasterization has been disabled on this configuration. BUG=653538 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=zmo@chromium.org Committed: https://crrev.com/516005ea9c2ffe59b5d468bf4673a549996010df Cr-Commit-Position: refs/heads/master@{#426972}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -4 lines) Patch
M content/test/gpu/gpu_tests/gpu_rasterization_expectations.py View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Ken Russell (switch to Gerrit)
FYI. CQ'ing TBR'd.
4 years, 2 months ago (2016-10-22 02:48:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442963002/1
4 years, 2 months ago (2016-10-22 02:48:53 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-22 04:34:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/516005ea9c2ffe59b5d468bf4673a549996010df Cr-Commit-Position: refs/heads/master@{#426972}
4 years, 2 months ago (2016-10-22 04:38:04 UTC) #10
ericrk
4 years, 1 month ago (2016-10-24 17:50:07 UTC) #11
Message was sent while issue was closed. 
A revert of this CL (patchset #1 id:1) has been created in
https://chromiumcodereview.appspot.com/2443283002/ by ericrk@chromium.org.

The reason for reverting is: Looks like the tests use --force-gpu-rasterization,
which overrides the blacklist. I think we still need this suppression.

See:
https://build.chromium.org/p/tryserver.chromium.angle/builders/win_angle_rel_...
https://build.chromium.org/p/chromium.gpu.fyi/builders/Win7%20Debug%20%28ATI%....

Powered by Google App Engine
This is Rietveld 408576698