Remove stl_util's deletion function use from chrome/.

chrome/browser/devtools/device/port_forwarding_controller.cc

Index: chrome/browser/devtools/device/port_forwarding_controller.cc
diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc
index 19ca9cd88bb53b5d9e5860c88929b6ae36c5b289..315aa5858e2b82e337cc88408d7c2392d54d3565 100644
--- a/chrome/browser/devtools/device/port_forwarding_controller.cc
+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc
@@ -467,9 +467,9 @@ PortForwardingController::DeviceListChanged(
 }
 
 void PortForwardingController::CloseAllConnections() {
-  std::vector<Connection*> registry_copy;
   Registry copy(registry_);
-  base::STLDeleteValues(&copy);
+  for (auto& entry : copy)
+    delete entry.second;

[Nico, 2016/10/24 18:41:01]

I don't understand why this is better than the lhs

[Avi (use Gerrit), 2016/10/24 19:15:37]

The existence of STLDelete* functions encourages people to use them rather than
proper owning containers. They're an attractive nuisance.

I couldn't figure out how to turn this into an owning container, so I'm
switching it to what it actually does. I argue that this is a net positive;
using STLDeleteValues implies that this has an owning container but is just
old-school, whereas switching to the delete loop makes it clear that it's
playing ownership games.

In any case, even if you disagree with me and say that it's not necessarily
better than before, making this switch lets me remove the STLDelete* functions,
which makes Chrome better-off overall.

[Nico, 2016/10/24 19:18:26]

That's a good motivation, thanks.

 }
 
 void PortForwardingController::OnPrefsChange() {