Remove stl_util's deletion function use from chrome/.

chrome/browser/devtools/device/port_forwarding_controller.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/device/port_forwarding_controller.h"
 
 #include <map>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 449 matching lines @@
       }
     } else {
       status.push_back(std::make_pair(rit->second->browser(),
                                       rit->second->GetPortStatusMap()));
     }
   }
   return status;
 }
 
 void PortForwardingController::CloseAllConnections() {
-  std::vector<Connection*> registry_copy;
   Registry copy(registry_);
-  base::STLDeleteValues(&copy);
+  for (auto& entry : copy)
+    delete entry.second;

[Nico, 2016/10/24 18:41:01]

I don't understand why this is better than the lhs

[Avi (use Gerrit), 2016/10/24 19:15:37]

The existence of STLDelete* functions encourages people to use them rather than
proper owning containers. They're an attractive nuisance.

I couldn't figure out how to turn this into an owning container, so I'm
switching it to what it actually does. I argue that this is a net positive;
using STLDeleteValues implies that this has an owning container but is just
old-school, whereas switching to the delete loop makes it clear that it's
playing ownership games.

In any case, even if you disagree with me and say that it's not necessarily
better than before, making this switch lets me remove the STLDelete* functions,
which makes Chrome better-off overall.

[Nico, 2016/10/24 19:18:26]

That's a good motivation, thanks.

 }
 
 void PortForwardingController::OnPrefsChange() {
   forwarding_map_.clear();
 
   if (pref_service_->GetBoolean(prefs::kDevToolsPortForwardingEnabled)) {
     const base::DictionaryValue* dict =
         pref_service_->GetDictionary(prefs::kDevToolsPortForwardingConfig);
     for (base::DictionaryValue::Iterator it(*dict);
          !it.IsAtEnd(); it.Advance()) {
       int port_num;
       std::string location;
       if (base::StringToInt(it.key(), &port_num) &&
           dict->GetString(it.key(), &location))
         forwarding_map_[port_num] = location;
     }
   }
 
   if (!forwarding_map_.empty())
     UpdateConnections();
   else
     CloseAllConnections();
 }
 
 void PortForwardingController::UpdateConnections() {
   for (Registry::iterator it = registry_.begin(); it != registry_.end(); ++it)
     it->second->UpdateForwardingMap(forwarding_map_);
 }