Control the VrShell content quad via the HTML UI.

Control the VrShell content quad via the HTML UI.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee
Cr-Commit-Position: refs/heads/master@{#427593}

[cjgrant, 2016-10-21 21:57:07]

Description was changed from

==========
Control the VrShell content quad via the HTML UI.

BUG=641508
==========

to

==========
Control the VrShell content quad via the HTML UI.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[cjgrant, 2016-10-21 22:01:34]

cjgrant@chromium.org changed reviewers:
+ bshe@chromium.org, mthiesse@chromium.org

[mthiesse, 2016-10-24 14:23:08]

lgtm

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene.cc:395: if (element-content_quad_) {
typo here?

[cjgrant, 2016-10-24 14:28:22]

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene.cc:395: if (element-content_quad_) {
On 2016/10/24 14:23:08, mthiesse wrote:
> typo here?

Are you saying you don't think this would compile?  ;)

Yeah, this is what happens when you refactor between the compile and upload
steps.  Sorry!

[bshe, 2016-10-24 18:09:39]

lgtm with a nit

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene.cc:397: content_quad_ = element;
nit: rename to content_element_ since it caches an element.

[cjgrant, 2016-10-26 01:10:00]

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
File chrome/browser/android/vr_shell/ui_scene.cc (right):

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene.cc:395: if (element-content_quad_) {
On 2016/10/24 14:28:21, cjgrant wrote:
> On 2016/10/24 14:23:08, mthiesse wrote:
> > typo here?
> 
> Are you saying you don't think this would compile?  ;)
> 
> Yeah, this is what happens when you refactor between the compile and upload
> steps.  Sorry!

Done.

https://codereview.chromium.org/2442873002/diff/1/chrome/browser/android/vr_s...
chrome/browser/android/vr_shell/ui_scene.cc:397: content_quad_ = element;
On 2016/10/24 18:09:38, bshe wrote:
> nit: rename to content_element_ since it caches an element.

Done.

[cjgrant, 2016-10-26 01:10:48]

The CQ bit was checked by cjgrant@chromium.org

[cjgrant, 2016-10-26 01:10:49]

The patchset sent to the CQ was uploaded after l-g-t-m from
mthiesse@chromium.org, bshe@chromium.org
Link to the patchset: https://codereview.chromium.org/2442873002/#ps40001
(title: "Rebase; address nits and bug.")

[commit-bot: I haz the power, 2016-10-26 01:11:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 02:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 02:21:42]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[cjgrant, 2016-10-26 03:25:47]

The CQ bit was checked by cjgrant@chromium.org

[commit-bot: I haz the power, 2016-10-26 03:26:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 04:59:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 05:01:00]

Description was changed from

==========
Control the VrShell content quad via the HTML UI.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Control the VrShell content quad via the HTML UI.

BUG=641508
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee
Cr-Commit-Position: refs/heads/master@{#427593}
==========

[commit-bot: I haz the power, 2016-10-26 05:01:01]

Patchset 3 (id:??) landed as
https://crrev.com/3d6a76c7ec3e75766018df88d95deea600c9afee
Cr-Commit-Position: refs/heads/master@{#427593}