Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2442733003:
third_party/freetype2: Add missing zlib dep. (Closed)
Descriptionthird_party/freetype2: Add missing zlib dep.
Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
Committed: https://crrev.com/8d505b4368140b37b6a77727991e81280ceb5e6c
Cr-Commit-Position: refs/heads/master@{#426998}
Patch Set 1 #
Messages
Total messages: 17 (8 generated)
Description was changed from
==========
third_party/freetype2: Add missing zlib dep.
Add zlib dependency to third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
==========
to
==========
third_party/freetype2: Add missing zlib dep.
Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
==========
jbriance@cisco.com changed reviewers: + dpranke@chromium.org
jbriance@cisco.com changed reviewers: + brettw@chromium.org
+ brettw
lgtm
The CQ bit was checked by jbriance@cisco.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
The CQ bit was checked by jbriance@cisco.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from
==========
third_party/freetype2: Add missing zlib dep.
Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
==========
to
==========
third_party/freetype2: Add missing zlib dep.
Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from
==========
third_party/freetype2: Add missing zlib dep.
Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
==========
to
==========
third_party/freetype2: Add missing zlib dep.
Add zlib dependency in third_party/freetype2/BUILD.gn, as it is
already done in third_party/freetype-android/BUILD.gn to fix the
following compilation error:
../../src/third_party/freetype2/src/src/gzip/ftgzip.c:49:18: fatal
error: zlib.h: No such file or directory
BUG=none
Committed: https://crrev.com/8d505b4368140b37b6a77727991e81280ceb5e6c
Cr-Commit-Position: refs/heads/master@{#426998}
==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8d505b4368140b37b6a77727991e81280ceb5e6c Cr-Commit-Position: refs/heads/master@{#426998}
Message was sent while issue was closed.
lgtm also (sorry for the delay). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
