Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1072)

Issue 2442563002: Access SigninErrorProvider through ChromeBrowserProvider. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
justincohen
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Access SigninErrorProvider through ChromeBrowserProvider. BUG=475439 Committed: https://crrev.com/3b9a4290a32aac71c4c94af4d530acc4f5c713e7 Cr-Commit-Position: refs/heads/master@{#427054}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -9 lines) Patch
M ios/chrome/browser/signin/profile_oauth2_token_service_ios_provider_impl.mm View 1 chunk +6 lines, -7 lines 0 comments Download
M ios/chrome/browser/signin/signin_util.mm View 2 chunks +3 lines, -1 line 0 comments Download
M ios/public/provider/chrome/browser/signin/fake_chrome_identity_interaction_manager.mm View 2 chunks +3 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
sdefresne
Please take a look but do not send to CQ as it requires downstream changes.
4 years, 2 months ago (2016-10-20 19:59:38 UTC) #3
justincohen
lgtm
4 years, 2 months ago (2016-10-21 02:53:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2442563002/1
4 years, 1 month ago (2016-10-24 12:32:01 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-24 12:58:50 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 13:00:50 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3b9a4290a32aac71c4c94af4d530acc4f5c713e7
Cr-Commit-Position: refs/heads/master@{#427054}

Powered by Google App Engine
This is Rietveld 408576698