Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2438603004: Remove old getter/setter for SigninErrorProvider. (Closed)

Created:
4 years, 2 months ago by sdefresne
Modified:
4 years, 1 month ago
Reviewers:
bzanotti
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove global getter/setter for SigninErrorProvider. BUG=475439 Committed: https://crrev.com/fce0ed59b599c9ecd145d95398796cc6244f1660 Cr-Commit-Position: refs/heads/master@{#427696}

Patch Set 1 #

Patch Set 2 : Rebase. #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M ios/public/provider/chrome/browser/signin/signin_error_provider.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/signin/signin_error_provider.mm View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
sdefresne
Please take a look.
4 years, 2 months ago (2016-10-20 15:33:12 UTC) #4
bzanotti
lgtm
4 years, 2 months ago (2016-10-20 16:49:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2438603004/60001
4 years, 1 month ago (2016-10-26 15:15:23 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-26 15:26:10 UTC) #20
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 15:44:59 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/fce0ed59b599c9ecd145d95398796cc6244f1660
Cr-Commit-Position: refs/heads/master@{#427696}

Powered by Google App Engine
This is Rietveld 408576698