GN: Build the SDK with app snapshots instead of script snapshots.

GN: Build the SDK with app snapshots instead of script snapshots.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/af7bf4dab0b13a72c4f8ea86e4d3db364e845bac

[rmacnak, 2016-10-21 00:52:07]

rmacnak@google.com changed reviewers:
+ asiva@google.com, zra@google.com

[zra, 2016-10-21 15:25:24]

lgtm w/ optional cleanup

https://codereview.chromium.org/2442513003/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/2442513003/diff/20001/BUILD.gn#newcode59
BUILD.gn:59: "utils/compiler:dart2js",
"utils/compiler" see note there.

https://codereview.chromium.org/2442513003/diff/20001/utils/compiler/BUILD.gn
File utils/compiler/BUILD.gn (right):

https://codereview.chromium.org/2442513003/diff/20001/utils/compiler/BUILD.gn...
utils/compiler/BUILD.gn:73: }
Maybe add:

group("compiler") {
  deps = [
    ":dart2js",
    ":utils_wrapper"
  ]
}

so that we just say "utils/compiler" in the root BUILD.gn file.

[rmacnak, 2016-10-22 00:39:47]

https://codereview.chromium.org/2442513003/diff/20001/utils/compiler/BUILD.gn
File utils/compiler/BUILD.gn (right):

https://codereview.chromium.org/2442513003/diff/20001/utils/compiler/BUILD.gn...
utils/compiler/BUILD.gn:73: }
On 2016/10/21 15:25:24, zra wrote:
> Maybe add:
> 
> group("compiler") {
>   deps = [
>     ":dart2js",
>     ":utils_wrapper"
>   ]
> }
> 
> so that we just say "utils/compiler" in the root BUILD.gn file.

Done.

[rmacnak, 2016-10-22 00:40:26]

Description was changed from

==========
GN: Build the SDK with app snapshots instead of script snapshots.
==========

to

==========
GN: Build the SDK with app snapshots instead of script snapshots.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/af7bf4dab0b13a72c4f8ea86e4d3db364e845bac
==========

[rmacnak, 2016-10-22 00:40:27]

Committed patchset #2 (id:20001) manually as
af7bf4dab0b13a72c4f8ea86e4d3db364e845bac (presubmit successful).