Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(431)

Unified Diff: utils/compiler/BUILD.gn

Issue 2442513003: GN: Build the SDK with app snapshots instead of script snapshots. (Closed)
Patch Set: . Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: utils/compiler/BUILD.gn
diff --git a/utils/compiler/BUILD.gn b/utils/compiler/BUILD.gn
index 52645050d69aebecc2e07d593f1f066c1fdff2be..2095edb8bf6ae64bfaa3d13fe4e36b4282736af0 100644
--- a/utils/compiler/BUILD.gn
+++ b/utils/compiler/BUILD.gn
@@ -20,35 +20,54 @@ create_timestamp_file("dartdoc_files_stamp") {
output = "$target_gen_dir/dartdoc_files.stamp"
}
-invoke_dart("dart2js") {
+invoke_dart("dart2js_create_snapshot_entries") {
deps = [
":dart2js_files_stamp",
":runtime_lib_files_stamp",
":dartdoc_files_stamp",
]
+ dot_packages = rebase_path("../../.packages")
+ create_snapshot_entry = rebase_path("create_snapshot_entry.dart")
+ output_dir = rebase_path(root_gen_dir)
+
inputs = [
"../../sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart",
- "create_snapshot.dart",
+ create_snapshot_entry,
"$root_gen_dir/dart2js_files.stamp",
"../../tools/VERSION",
]
- utils_output = "$root_gen_dir/utils_wrapper.dart.snapshot"
- dart2js_output = "$root_gen_dir/dart2js.dart.snapshot"
+ utils_output = "$root_gen_dir/utils_wrapper.dart"
+ dart2js_output = "$root_gen_dir/dart2js.dart"
outputs = [
utils_output,
dart2js_output,
]
- dot_packages = rebase_path("../../.packages")
- create_snapshot = rebase_path("create_snapshot.dart")
- output_dir = rebase_path(root_gen_dir)
-
args = [
"--packages=$dot_packages",
- create_snapshot,
+ create_snapshot_entry,
"--output_dir=$output_dir",
"--dart2js_main=pkg/compiler/lib/src/dart2js.dart",
]
}
+
+application_snapshot("dart2js") {
+ deps = [
+ ":dart2js_create_snapshot_entries"
+ ]
+ main_dart = "$root_gen_dir/dart2js.dart"
+ training_args = [
+ "--library-root=" + rebase_path("../../sdk"),
+ rebase_path("../../tests/language/first_test.dart")
+ ]
+}
+
+application_snapshot("utils_wrapper") {
+ deps = [
+ ":dart2js_create_snapshot_entries"
+ ]
+ main_dart = "$root_gen_dir/utils_wrapper.dart"
+ training_args = [ "--help" ]
+}
zra 2016/10/21 15:25:24 Maybe add: group("compiler") { deps = [ ":d
rmacnak 2016/10/22 00:39:47 Done.

Powered by Google App Engine
This is Rietveld 408576698