[heap] Uncommit marking deque in concurrent task.

[heap] Uncommit marking deque in concurrent task.

BUG=

Committed: https://crrev.com/8d5acea950260fe5fbea3b7f276de80ee362c464
Cr-Commit-Position: refs/heads/master@{#40585}

[ulan, 2016-10-21 15:14:02]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-21 15:14:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ulan, 2016-10-21 15:15:13]

ulan@chromium.org changed reviewers:
+ mlippautz@chromium.org

[ulan, 2016-10-21 15:15:13]

ptal

[Michael Lippautz, 2016-10-24 08:43:23]

lgtm % comments

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact....
src/heap/mark-compact.cc:2119: WaitForUncommitTask();
Maybe for future: Afaik, background tasks provide no guarantee on progress. In
theory, we should make the task cancelable, to be able to abort it here and make
progress on the main thread.

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact....
src/heap/mark-compact.h:136: if (!marking_deque_->in_use_) {
Can you somewhere document with a comment that in_use_ is used to indicate
whether the deque still needs to be uncommitted? Was quite puzzled how the
StartUsing() can get away without explicit waiting for the task.

[ulan, 2016-10-24 13:14:10]

ptal

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact....
src/heap/mark-compact.cc:2119: WaitForUncommitTask();
On 2016/10/24 08:43:23, Michael Lippautz wrote:
> Maybe for future: Afaik, background tasks provide no guarantee on progress. In
> theory, we should make the task cancelable, to be able to abort it here and
make
> progress on the main thread.

I made the task cancelable.

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact.h
File src/heap/mark-compact.h (right):

https://codereview.chromium.org/2442443003/diff/100001/src/heap/mark-compact....
src/heap/mark-compact.h:136: if (!marking_deque_->in_use_) {
On 2016/10/24 08:43:23, Michael Lippautz wrote:
> Can you somewhere document with a comment that in_use_ is used to indicate
> whether the deque still needs to be uncommitted? Was quite puzzled how the
> StartUsing() can get away without explicit waiting for the task.

Done.

[ulan, 2016-10-24 13:33:12]

The CQ bit was checked by ulan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-24 13:33:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Michael Lippautz, 2016-10-24 13:34:03]

lgtm

https://codereview.chromium.org/2442443003/diff/120001/src/heap/mark-compact.cc
File src/heap/mark-compact.cc (right):

https://codereview.chromium.org/2442443003/diff/120001/src/heap/mark-compact....
src/heap/mark-compact.cc:2128: // started using the marking deque.
nit: This comment requires updating.

[commit-bot: I haz the power, 2016-10-24 14:31:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-24 14:31:26]

Dry run: This issue passed the CQ dry run.

[ulan, 2016-10-26 11:02:05]

The CQ bit was checked by ulan@chromium.org

[commit-bot: I haz the power, 2016-10-26 11:02:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 12:02:20]

Committed patchset #7 (id:120001)

[Michael Achenbach, 2016-10-26 12:39:02]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2454693002/ by machenbach@chromium.org.

The reason for reverting is: Seems to break the world, e.g.:
https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/14118.

[commit-bot: I haz the power, 2016-11-17 22:13:41]

Description was changed from

==========
[heap] Uncommit marking deque in concurrent task.

BUG=
==========

to

==========
[heap] Uncommit marking deque in concurrent task.

BUG=

Committed: https://crrev.com/8d5acea950260fe5fbea3b7f276de80ee362c464
Cr-Commit-Position: refs/heads/master@{#40585}
==========

[commit-bot: I haz the power, 2016-11-17 22:13:46]

Patchset 7 (id:??) landed as
https://crrev.com/8d5acea950260fe5fbea3b7f276de80ee362c464
Cr-Commit-Position: refs/heads/master@{#40585}